Re: [PATCHv2] Optab: add isfinite_optab for __builtin_isfinite

2024-05-27 Thread Kewen.Lin
Hi Haochen, on 2024/5/27 15:22, HAO CHEN GUI wrote: > Hi Kewen, > Thanks for your comments. > > 在 2024/5/27 11:18, Kewen.Lin 写道: >> Does this require "This pattern is not allowed to FAIL."? >> >> I guess yes? Since if it's decided to go with this pattern >> expanding, there is no fall back? >

Re: [PATCHv2] Optab: add isfinite_optab for __builtin_isfinite

2024-05-27 Thread HAO CHEN GUI
Hi Kewen, Thanks for your comments. 在 2024/5/27 11:18, Kewen.Lin 写道: > Does this require "This pattern is not allowed to FAIL."? > > I guess yes? Since if it's decided to go with this pattern > expanding, there is no fall back? The builtin is inline folded if the optab doesn't exist on the

Re: Ping [PATCHv2] Optab: add isfinite_optab for __builtin_isfinite

2024-05-26 Thread Richard Biener
On Mon, May 27, 2024 at 4:10 AM HAO CHEN GUI wrote: > > Hi, > Gently ping it. > https://gcc.gnu.org/pipermail/gcc-patches/2024-May/652170.html > > Thanks > Gui Haochen > > 在 2024/5/20 16:15, HAO CHEN GUI 写道: > > Hi, > > This patch adds an optab for __builtin_isfinite. The finite check can be >

Re: [PATCHv2] Optab: add isfinite_optab for __builtin_isfinite

2024-05-26 Thread Kewen.Lin
Hi, on 2024/5/20 16:15, HAO CHEN GUI wrote: > Hi, > This patch adds an optab for __builtin_isfinite. The finite check can be > implemented on rs6000 by a single instruction. It needs an optab to be > expanded to the certain sequence of instructions. > > The subsequent patches will implement t

Ping [PATCHv2] Optab: add isfinite_optab for __builtin_isfinite

2024-05-26 Thread HAO CHEN GUI
Hi, Gently ping it. https://gcc.gnu.org/pipermail/gcc-patches/2024-May/652170.html Thanks Gui Haochen 在 2024/5/20 16:15, HAO CHEN GUI 写道: > Hi, > This patch adds an optab for __builtin_isfinite. The finite check can be > implemented on rs6000 by a single instruction. It needs an optab to be >

[PATCHv2] Optab: add isfinite_optab for __builtin_isfinite

2024-05-20 Thread HAO CHEN GUI
Hi, This patch adds an optab for __builtin_isfinite. The finite check can be implemented on rs6000 by a single instruction. It needs an optab to be expanded to the certain sequence of instructions. The subsequent patches will implement the expand on rs6000. Compared to previous version, the