Re: [PATCHv2] Add a warning for invalid function casts

2017-11-30 Thread Jason Merrill
On Thu, Nov 30, 2017 at 1:23 PM, Bernd Edlinger wrote: > On 11/30/17 19:05, Jason Merrill wrote: >> On Thu, Nov 30, 2017 at 12:55 PM, Bernd Edlinger >> wrote: >>> On 11/30/17 18:29, Jason Merrill wrote: On Thu, Nov 30, 2017 at 11:07 AM, Bernd Edlinger wrote: > On 11/30/17 16:45, Ja

Re: [PATCHv2] Add a warning for invalid function casts

2017-11-30 Thread Bernd Edlinger
On 11/30/17 19:05, Jason Merrill wrote: > On Thu, Nov 30, 2017 at 12:55 PM, Bernd Edlinger > wrote: >> On 11/30/17 18:29, Jason Merrill wrote: >>> On Thu, Nov 30, 2017 at 11:07 AM, Bernd Edlinger >>> wrote: On 11/30/17 16:45, Jason Merrill wrote: > On Thu, Nov 30, 2017 at 10:14 AM, Bernd

Re: [PATCHv2] Add a warning for invalid function casts

2017-11-30 Thread Jason Merrill
On Thu, Nov 30, 2017 at 12:55 PM, Bernd Edlinger wrote: > On 11/30/17 18:29, Jason Merrill wrote: >> On Thu, Nov 30, 2017 at 11:07 AM, Bernd Edlinger >> wrote: >>> On 11/30/17 16:45, Jason Merrill wrote: On Thu, Nov 30, 2017 at 10:14 AM, Bernd Edlinger wrote: > On 11/29/17 22:57, J

Re: [PATCHv2] Add a warning for invalid function casts

2017-11-30 Thread Bernd Edlinger
On 11/30/17 18:29, Jason Merrill wrote: > On Thu, Nov 30, 2017 at 11:07 AM, Bernd Edlinger > wrote: >> On 11/30/17 16:45, Jason Merrill wrote: >>> On Thu, Nov 30, 2017 at 10:14 AM, Bernd Edlinger >>> wrote: On 11/29/17 22:57, Jason Merrill wrote: > On 10/09/2017 06:30 PM, Bernd Edlinger

Re: [PATCHv2] Add a warning for invalid function casts

2017-11-30 Thread Jason Merrill
On Thu, Nov 30, 2017 at 11:07 AM, Bernd Edlinger wrote: > On 11/30/17 16:45, Jason Merrill wrote: >> On Thu, Nov 30, 2017 at 10:14 AM, Bernd Edlinger >> wrote: >>> On 11/29/17 22:57, Jason Merrill wrote: On 10/09/2017 06:30 PM, Bernd Edlinger wrote: >> > + if (INTEGRAL_TYPE_P (t1) >

Re: [PATCHv2] Add a warning for invalid function casts

2017-11-30 Thread Bernd Edlinger
On 11/30/17 16:45, Jason Merrill wrote: > On Thu, Nov 30, 2017 at 10:14 AM, Bernd Edlinger > wrote: >> On 11/29/17 22:57, Jason Merrill wrote: >>> On 10/09/2017 06:30 PM, Bernd Edlinger wrote: > + if (INTEGRAL_TYPE_P (t1) + && INTEGRAL_TYPE_P (t2) + && TYPE_PRECISION (t1

Re: [PATCHv2] Add a warning for invalid function casts

2017-11-30 Thread Jason Merrill
On Thu, Nov 30, 2017 at 10:14 AM, Bernd Edlinger wrote: > On 11/29/17 22:57, Jason Merrill wrote: >> On 10/09/2017 06:30 PM, Bernd Edlinger wrote: >>> + if (INTEGRAL_TYPE_P (t1) >>> + && INTEGRAL_TYPE_P (t2) >>> + && TYPE_PRECISION (t1) == TYPE_PRECISION (t2) >>> + && (TYPE_UNSIGN

[PATCHv2] Add a warning for invalid function casts

2017-11-30 Thread Bernd Edlinger
On 11/29/17 22:57, Jason Merrill wrote: > On 10/09/2017 06:30 PM, Bernd Edlinger wrote: >> +/* Heuristic check if two parameter types can be considered >> ABI-equivalent.  */ >> + >> +static bool >> +cxx_abi_equiv_type_p (tree t1, tree t2) > > This name is too general for a function that is speci