Re: [PATCHv2][PR 57371] Remove useless floating point casts in comparisons

2017-07-10 Thread Joseph Myers
On Mon, 10 Jul 2017, Yuri Gribov wrote: > On Mon, Jul 10, 2017 at 11:06 AM, Joseph Myers > wrote: > > On Sat, 8 Jul 2017, Yuri Gribov wrote: > > > >> On Fri, Jul 7, 2017 at 11:51 PM, Joseph Myers > >> wrote: > >> > On Fri, 7 Jul 2017, Yuri Gribov wrote: > >> > > >> >> > I suspect infinities wo

Re: [PATCHv2][PR 57371] Remove useless floating point casts in comparisons

2017-07-10 Thread Yuri Gribov
On Mon, Jul 10, 2017 at 11:06 AM, Joseph Myers wrote: > On Sat, 8 Jul 2017, Yuri Gribov wrote: > >> On Fri, Jul 7, 2017 at 11:51 PM, Joseph Myers >> wrote: >> > On Fri, 7 Jul 2017, Yuri Gribov wrote: >> > >> >> > I suspect infinities would already work with the patch as-is (the logic >> >> > dea

Re: [PATCHv2][PR 57371] Remove useless floating point casts in comparisons

2017-07-10 Thread Joseph Myers
On Sat, 8 Jul 2017, Yuri Gribov wrote: > On Fri, Jul 7, 2017 at 11:51 PM, Joseph Myers wrote: > > On Fri, 7 Jul 2017, Yuri Gribov wrote: > > > >> > I suspect infinities would already work with the patch as-is (the logic > >> > dealing with constants outside the range of the integer type). I'm le

Re: [PATCHv2][PR 57371] Remove useless floating point casts in comparisons

2017-07-07 Thread Yuri Gribov
On Sat, Jul 8, 2017 at 5:30 AM, Yuri Gribov wrote: > On Fri, Jul 7, 2017 at 11:51 PM, Joseph Myers wrote: >> On Fri, 7 Jul 2017, Yuri Gribov wrote: >> >>> > I suspect infinities would already work with the patch as-is (the logic >>> > dealing with constants outside the range of the integer type).

Re: [PATCHv2][PR 57371] Remove useless floating point casts in comparisons

2017-07-07 Thread Yuri Gribov
On Fri, Jul 7, 2017 at 11:51 PM, Joseph Myers wrote: > On Fri, 7 Jul 2017, Yuri Gribov wrote: > >> > I suspect infinities would already work with the patch as-is (the logic >> > dealing with constants outside the range of the integer type). I'm less >> > clear that NaNs would work properly. (If

Re: [PATCHv2][PR 57371] Remove useless floating point casts in comparisons

2017-07-07 Thread Joseph Myers
On Fri, 7 Jul 2017, Yuri Gribov wrote: > > I suspect infinities would already work with the patch as-is (the logic > > dealing with constants outside the range of the integer type). I'm less > > clear that NaNs would work properly. (If the comparison is == or != you > > can optimize it for quiet

Re: [PATCHv2][PR 57371] Remove useless floating point casts in comparisons

2017-07-07 Thread Yuri Gribov
On Fri, Jul 7, 2017 at 6:07 PM, Joseph Myers wrote: > On Fri, 7 Jul 2017, Yuri Gribov wrote: > >> Hi all, >> >> This is an updated version of patch in >> https://gcc.gnu.org/ml/gcc-patches/2017-07/msg00034.html . It should >> be much more complete, both in functionality and in tests. > > I think t

Re: [PATCHv2][PR 57371] Remove useless floating point casts in comparisons

2017-07-07 Thread Joseph Myers
On Fri, 7 Jul 2017, Yuri Gribov wrote: > Hi all, > > This is an updated version of patch in > https://gcc.gnu.org/ml/gcc-patches/2017-07/msg00034.html . It should > be much more complete, both in functionality and in tests. I think there should be tests when the constant is an infinity (of eithe

[PATCHv2][PR 57371] Remove useless floating point casts in comparisons

2017-07-06 Thread Yuri Gribov
Hi all, This is an updated version of patch in https://gcc.gnu.org/ml/gcc-patches/2017-07/msg00034.html . It should be much more complete, both in functionality and in tests. Bootstrapped and regtested on x64. Ok for trunk? -Y pr57371-2.patch Description: Binary data