RE: RE: [PATCH v9] RISC-V: Refactor requirement of ZVFH and ZVFHMIN.

2023-06-09 Thread Li, Pan2 via Gcc-patches
Cc: Robin Dapp ; jeffreyalaw ; Wang, Yanzhang ; kito.cheng Subject: RE: RE: [PATCH v9] RISC-V: Refactor requirement of ZVFH and ZVFHMIN. By logically, Yes, we should not change that but here I would like to put all enable related code together, will remove this part as it may has no

RE: RE: [PATCH v9] RISC-V: Refactor requirement of ZVFH and ZVFHMIN.

2023-06-08 Thread Li, Pan2 via Gcc-patches
; jeffreyalaw ; Wang, Yanzhang ; kito.cheng Subject: Re: RE: [PATCH v9] RISC-V: Refactor requirement of ZVFH and ZVFHMIN. OK. But why change the place of these -;; ISA attributes. -(define_attr "ext" "base,f,d,vector" - (const_string "base")) - -;; True if the exten

Re: RE: [PATCH v9] RISC-V: Refactor requirement of ZVFH and ZVFHMIN.

2023-06-08 Thread juzhe.zh...@rivai.ai
t;yes") - - (and (eq_attr "ext" "vector") - (match_test "TARGET_VECTOR")) - (const_string "yes") - ] - (const_string "no"))) I think it should not be changed. juzhe.zh...@rivai.ai From: Li, Pan2 Date: 2023-06-09 14:23 To: juzhe.zh..

RE: [PATCH v9] RISC-V: Refactor requirement of ZVFH and ZVFHMIN.

2023-06-08 Thread Li, Pan2 via Gcc-patches
gt;> thing is removed? The same as above, move to the place after than type attr definition and only add fp_vector_disable here. >> This should be in vector.md instead of riscv.md It will trigger "unknown attribute `fp_vector_disabled' in definition of attribute `enabled'"

Re: [PATCH v9] RISC-V: Refactor requirement of ZVFH and ZVFHMIN.

2023-06-08 Thread juzhe.zh...@rivai.ai
t;) + (and (eq_attr "mode" "VNx1HF,VNx2HF,VNx4HF,VNx8HF,VNx16HF,VNx32HF,VNx64HF") + (match_test "!TARGET_ZVFH"))) +(const_string "yes") + +(and (eq_attr "type" "vfncvtftoi,vfwcvtitof") + (and (eq_attr "mode" "VN

[PATCH v9] RISC-V: Refactor requirement of ZVFH and ZVFHMIN.

2023-06-08 Thread Pan Li via Gcc-patches
From: Pan Li This patch would like to refactor the requirement of both the ZVFH and ZVFHMIN. By default, the ZVFHMIN will enable FP16 for all the iterators of RVV. And then the ZVFH will leverage one define attr the gate for FP16 supported or not. Please note the ZVFH will cover the ZVFHMIN inst