Re: [PATCH v7] Missed function specialization + partial devirtualization

2020-01-15 Thread Jan Hubicka
> On Wed, Jan 15, 2020 at 1:37 PM Jan Hubicka wrote: > > > > > gcc/ChangeLog: > > > > > > 2020-01-15 Martin Liska > > > > > > * ipa-profile.c (ipa_profile_read_edge_summary): Do not allow > > > 2 calls of streamer_read_hwi in a function call. > > > > Good catch, Martin! > > > --- >

Re: [PATCH v7] Missed function specialization + partial devirtualization

2020-01-15 Thread Richard Biener
On Wed, Jan 15, 2020 at 1:37 PM Jan Hubicka wrote: > > > gcc/ChangeLog: > > > > 2020-01-15 Martin Liska > > > > * ipa-profile.c (ipa_profile_read_edge_summary): Do not allow > > 2 calls of streamer_read_hwi in a function call. > > Good catch, Martin! > > --- > > gcc/ipa-profile.c |

Re: [PATCH v7] Missed function specialization + partial devirtualization

2020-01-15 Thread Jan Hubicka
> gcc/ChangeLog: > > 2020-01-15 Martin Liska > > * ipa-profile.c (ipa_profile_read_edge_summary): Do not allow > 2 calls of streamer_read_hwi in a function call. Good catch, Martin! > --- > gcc/ipa-profile.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff -

Re: [PATCH v7] Missed function specialization + partial devirtualization

2020-01-15 Thread Martin Liška
On 1/15/20 11:49 AM, Martin Liška wrote: Hi. I know the root cause of the failure and will send a patch soon to the mailing list. Martin There's an obvious patch that I'm going to install. Note that order of function call evaluation in a function call is undefined. It's a similar issue we had

Re: [PATCH v7] Missed function specialization + partial devirtualization

2020-01-15 Thread Martin Liška
Hi. I know the root cause of the failure and will send a patch soon to the mailing list. Martin

Re: [PATCH v7] Missed function specialization + partial devirtualization

2020-01-15 Thread Christophe Lyon
Hi, On Tue, 14 Jan 2020 at 15:35, luoxhu wrote: > > Hi, > > On 2020/1/14 21:03, Martin Liška wrote: > > On 1/13/20 4:23 AM, luoxhu wrote: > >> Thanks a lot! Rebased & updated, will commit below patch shortly when > >> git push is ready. > > > > Hello. > > > > I'm pretty sure the patch contains

Re: [PATCH v7] Missed function specialization + partial devirtualization

2020-01-14 Thread David Malcolm
On Mon, 2020-01-13 at 11:23 +0800, luoxhu wrote: > On 2020/1/10 19:08, Jan Hubicka wrote: > > OK. You will need to do the obvious updates for Martin's patch > > which turned some member functions into static functions. > > > > Honza > > Thanks a lot! Rebased & updated, will commit below patch sh

Re: [PATCH v7] Missed function specialization + partial devirtualization

2020-01-14 Thread Martin Liška
On 1/13/20 4:23 AM, luoxhu wrote: Thanks a lot! Rebased & updated, will commit below patch shortly when git push is ready. Hello. I'm pretty sure the patch contains failure of the following tests: FAIL: gcc.dg/tree-prof/crossmodule-indir-call-topn-1.c scan-pgo-wpa-ipa-dump profile_estimate

Re: [PATCH v7] Missed function specialization + partial devirtualization

2020-01-12 Thread luoxhu
On 2020/1/10 19:08, Jan Hubicka wrote: > OK. You will need to do the obvious updates for Martin's patch > which turned some member functions into static functions. > > Honza Thanks a lot! Rebased & updated, will commit below patch shortly when git push is ready. v8: 1. Rebase to master with

Re: [PATCH v7] Missed function specialization + partial devirtualization

2020-01-10 Thread Jan Hubicka
> > I think you are also not removing the common_target and > > common_target_probability from cgraph_edge. > > There is now code in ipa-utils merging the histograms. You will need to > > update that to your representation. It should not be hard - it either > > copies all the values from target fun

[PATCH v7] Missed function specialization + partial devirtualization

2019-12-25 Thread luoxhu
>>> profile_count indir_cnt = indirect->count; >>> indirect = indirect->clone (id->dst_node, call_stmt, >>> gimple_uid (stmt), >>> num, den, >>>