Re: [PATCH v5 7/8] libstdc++: Add tests for layout_stride.

2025-06-04 Thread Tomasz Kaminski
On Wed, Jun 4, 2025 at 5:45 PM Luc Grosheintz wrote: > > > On 6/4/25 15:38, Tomasz Kaminski wrote: > > On Wed, Jun 4, 2025 at 2:19 PM Tomasz Kaminski > wrote: > > > >> > >> > >> On Wed, Jun 4, 2025 at 2:05 PM Luc Grosheintz > > >> wrote: > >> > >>> > >>> > >>> On 6/4/25 13:19, Tomasz Kaminski w

Re: [PATCH v5 7/8] libstdc++: Add tests for layout_stride.

2025-06-04 Thread Luc Grosheintz
On 6/4/25 15:38, Tomasz Kaminski wrote: On Wed, Jun 4, 2025 at 2:19 PM Tomasz Kaminski wrote: On Wed, Jun 4, 2025 at 2:05 PM Luc Grosheintz wrote: On 6/4/25 13:19, Tomasz Kaminski wrote: Ah, sorry I got confused in the review suggestions, and latter when checking the code. What I me

Re: [PATCH v5 7/8] libstdc++: Add tests for layout_stride.

2025-06-04 Thread Tomasz Kaminski
On Wed, Jun 4, 2025 at 2:19 PM Tomasz Kaminski wrote: > > > On Wed, Jun 4, 2025 at 2:05 PM Luc Grosheintz > wrote: > >> >> >> On 6/4/25 13:19, Tomasz Kaminski wrote: >> > Ah, sorry I got confused in the review suggestions, and latter when >> > checking the code. >> > What I meant is: >> > >> > B

Re: [PATCH v5 7/8] libstdc++: Add tests for layout_stride.

2025-06-04 Thread Tomasz Kaminski
On Wed, Jun 4, 2025 at 2:05 PM Luc Grosheintz wrote: > > > On 6/4/25 13:19, Tomasz Kaminski wrote: > > Ah, sorry I got confused in the review suggestions, and latter when > > checking the code. > > What I meant is: > > > > Because the incoming strided_layout is required to be unique, > > that imp

Re: [PATCH v5 7/8] libstdc++: Add tests for layout_stride.

2025-06-04 Thread Luc Grosheintz
On 6/4/25 13:19, Tomasz Kaminski wrote: Ah, sorry I got confused in the review suggestions, and latter when checking the code. What I meant is: Because the incoming strided_layout is required to be unique, that implies that for each of strides are greater or equal to the extents. As a consequ

Re: [PATCH v5 7/8] libstdc++: Add tests for layout_stride.

2025-06-04 Thread Tomasz Kaminski
On Wed, Jun 4, 2025 at 1:19 PM Tomasz Kaminski wrote: > Ah, sorry I got confused in the review suggestions, and latter when > checking the code. > What I meant is: > > Because the incoming strided_layout is required to be unique, > that implies that for each of strides are greater or equal to the

Re: [PATCH v5 7/8] libstdc++: Add tests for layout_stride.

2025-06-04 Thread Tomasz Kaminski
Ah, sorry I got confused in the review suggestions, and latter when checking the code. What I meant is: Because the incoming strided_layout is required to be unique, that implies that for each of strides are greater or equal to the extents. As a consequence, other.required_span_size() is always gr

Re: [PATCH v5 7/8] libstdc++: Add tests for layout_stride.

2025-06-04 Thread Luc Grosheintz
On 6/3/25 15:24, Tomasz Kaminski wrote: On Fri, May 30, 2025 at 6:44 PM Luc Grosheintz wrote: Implements the tests for layout_stride and for the features of the other two layouts that depend on layout_stride. libstdc++-v3/ChangeLog: * testsuite/23_containers/mdspan/layouts/class_

Re: [PATCH v5 7/8] libstdc++: Add tests for layout_stride.

2025-06-03 Thread Tomasz Kaminski
On Fri, May 30, 2025 at 6:44 PM Luc Grosheintz wrote: > Implements the tests for layout_stride and for the features of the other > two layouts that depend on layout_stride. > > libstdc++-v3/ChangeLog: > > * testsuite/23_containers/mdspan/layouts/class_mandate_neg.cc: Add > tests f

[PATCH v5 7/8] libstdc++: Add tests for layout_stride.

2025-05-30 Thread Luc Grosheintz
Implements the tests for layout_stride and for the features of the other two layouts that depend on layout_stride. libstdc++-v3/ChangeLog: * testsuite/23_containers/mdspan/layouts/class_mandate_neg.cc: Add tests for layout_stride. * testsuite/23_containers/mdspan/layouts/c