Re: [PATCH v4 2/3] Add predict_doloop_p target hook

on 2019/6/17 下午9:44, Richard Biener wrote: > On Mon, 17 Jun 2019, Kewen.Lin wrote: > >> on 2019/6/17 下午8:08, Richard Biener wrote: >>> On June 17, 2019 11:59:30 AM GMT+02:00, Segher Boessenkool >>> wrote: On Mon, Jun 17, 2019 at 10:51:49AM +0200, Richard Biener wrote: > On Mon, 17 Jun 2

Re: [PATCH v4 2/3] Add predict_doloop_p target hook

On Mon, 17 Jun 2019, Kewen.Lin wrote: > on 2019/6/17 下午8:08, Richard Biener wrote: > > On June 17, 2019 11:59:30 AM GMT+02:00, Segher Boessenkool > > wrote: > >> On Mon, Jun 17, 2019 at 10:51:49AM +0200, Richard Biener wrote: > >>> On Mon, 17 Jun 2019, Kewen.Lin wrote: > >>> > Hi Segher and

Re: [PATCH v4 2/3] Add predict_doloop_p target hook

on 2019/6/17 下午8:08, Richard Biener wrote: > On June 17, 2019 11:59:30 AM GMT+02:00, Segher Boessenkool > wrote: >> On Mon, Jun 17, 2019 at 10:51:49AM +0200, Richard Biener wrote: >>> On Mon, 17 Jun 2019, Kewen.Lin wrote: >>> Hi Segher and Bill, Thanks a lot for your review comment

Re: [PATCH v4 2/3] Add predict_doloop_p target hook

On June 17, 2019 11:59:30 AM GMT+02:00, Segher Boessenkool wrote: >On Mon, Jun 17, 2019 at 10:51:49AM +0200, Richard Biener wrote: >> On Mon, 17 Jun 2019, Kewen.Lin wrote: >> >> > Hi Segher and Bill, >> > >> > Thanks a lot for your review comments! I've updated the patch >accordingly. >> > >>

Re: [PATCH v4 2/3] Add predict_doloop_p target hook

On Mon, Jun 17, 2019 at 10:51:49AM +0200, Richard Biener wrote: > On Mon, 17 Jun 2019, Kewen.Lin wrote: > > > Hi Segher and Bill, > > > > Thanks a lot for your review comments! I've updated the patch accordingly. > > > > The updated one attached. > > OK. I suppose all low-overhead loop instruc

Re: [PATCH v4 2/3] Add predict_doloop_p target hook

on 2019/6/17 下午4:51, Richard Biener wrote: > On Mon, 17 Jun 2019, Kewen.Lin wrote: > >> Hi Segher and Bill, >> >> Thanks a lot for your review comments! I've updated the patch accordingly. >> >> The updated one attached. > > OK. I suppose all low-overhead loop instructions use a decrement to zer

Re: [PATCH v4 2/3] Add predict_doloop_p target hook

On Mon, 17 Jun 2019, Kewen.Lin wrote: > Hi Segher and Bill, > > Thanks a lot for your review comments! I've updated the patch accordingly. > > The updated one attached. OK. I suppose all low-overhead loop instructions use a decrement to zero style iterator? Thanks, Richard.

Re: [PATCH v4 2/3] Add predict_doloop_p target hook

Hi Segher and Bill, Thanks a lot for your review comments! I've updated the patch accordingly. The updated one attached. diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c index 91fafc4e766..6667cd03042 100644 --- a/gcc/config/rs6000/rs6000.c +++ b/gcc/config/rs6000/rs6000.c @@

Re: [PATCH v4 2/3] Add predict_doloop_p target hook

On 6/14/19 4:53 PM, Segher Boessenkool wrote: > Hi Kewen, > > On Thu, Jun 13, 2019 at 01:50:05PM +0800, Kewen.Lin wrote: >> Comparing with the previous version, I dropped the checks >> on costly niter and invalid stmt scanning. As Richard's >> suggestion, keep this as simple as possible, refine

Re: [PATCH v4 2/3] Add predict_doloop_p target hook

Hi Kewen, On Thu, Jun 13, 2019 at 01:50:05PM +0800, Kewen.Lin wrote: > Comparing with the previous version, I dropped the checks > on costly niter and invalid stmt scanning. As Richard's > suggestion, keep this as simple as possible, refine it > if finding any cases which matter later. I think

[PATCH v4 2/3] Add predict_doloop_p target hook

Hi, Many thanks for all comments on previous versions. Comparing with the previous version, I dropped the checks on costly niter and invalid stmt scanning. As Richard's suggestion, keep this as simple as possible, refine it if finding any cases which matter later. Bootstrapped and regression t