Re: [PATCH v4 1/2] [APX CFCMOV] Support APX CFCMOV in if_convert pass

2024-11-28 Thread Richard Sandiford
Thanks for using maskload/store_optab and sorry for the very slow review. Been a bit swamped lately... The patch seems to be using maskload and maskstore as though they were variants of movMMcc, with the comparison being part of the load/store. Instead, the current interface is that: maskload

Re: [PATCH v4 1/2] [APX CFCMOV] Support APX CFCMOV in if_convert pass

2024-11-27 Thread Hongyu Wang
Ping^2 Hongyu Wang 于2024年11月21日周四 11:04写道: > > Gently ping, it would be appreciate if anyone can help review this. > We hope this patch will not miss GCC15 for complete support on APX. > > Kong, Lingling 于2024年11月14日周四 09:50写道: > > > > > Hi, > > > > Many thanks to Richard for the suggestion that

Re: [PATCH v4 1/2] [APX CFCMOV] Support APX CFCMOV in if_convert pass

2024-11-20 Thread Hongyu Wang
Gently ping, it would be appreciate if anyone can help review this. We hope this patch will not miss GCC15 for complete support on APX. Kong, Lingling 于2024年11月14日周四 09:50写道: > > Hi, > > Many thanks to Richard for the suggestion that conditional load is like a > scalar instance of maskload_opta

[PATCH v4 1/2] [APX CFCMOV] Support APX CFCMOV in if_convert pass

2024-11-13 Thread Kong, Lingling
Hi, Many thanks to Richard for the suggestion that conditional load is like a scalar instance of maskload_optab . So this version has use maskload and maskstore optab to expand and generate cfcmov in ifcvt pass. All the changes passed bootstrap & regtest x86-64-pc-linux-gnu. We also tested spec