Re: [PATCH v4 0/8] Implement layouts from mdspan.

2025-05-29 Thread Tomasz Kaminski
Sending a bit after the fact, but: I have finished the review, and most of the commits have really minimal cosmetic changes. The only major functional one I have requested are for layout_stride implementation, On Wed, May 28, 2025 at 4:36 PM Tomasz Kaminski wrote: > I have reviewed and posted fe

Re: [PATCH v4 0/8] Implement layouts from mdspan.

2025-05-28 Thread Tomasz Kaminski
I have reviewed and posted feedback up to, but not including layout_stride today. Will try to finish tomorrow. Thank you again for continuous work on the patches. On Tue, May 27, 2025 at 4:40 PM Tomasz Kaminski wrote: > > > On Tue, May 27, 2025 at 4:32 PM Luc Grosheintz > wrote: > >> Since, I b

Re: [PATCH v4 0/8] Implement layouts from mdspan.

2025-05-27 Thread Tomasz Kaminski
On Tue, May 27, 2025 at 4:32 PM Luc Grosheintz wrote: > Since, I believe now we're through the larger questions about > how to implement layouts. If reviewing all three over and over > is too painful, it might now make sense to split the patch into > separate patches, one per layout. > I think we

Re: [PATCH v4 0/8] Implement layouts from mdspan.

2025-05-27 Thread Luc Grosheintz
Since, I believe now we're through the larger questions about how to implement layouts. If reviewing all three over and over is too painful, it might now make sense to split the patch into separate patches, one per layout. On 5/26/25 16:04, Luc Grosheintz wrote: This follows up on: https://gcc.g

[PATCH v4 0/8] Implement layouts from mdspan.

2025-05-26 Thread Luc Grosheintz
This follows up on: https://gcc.gnu.org/pipermail/libstdc++/2025-May/061572.html Note that this patch series can only be applied after merging: https://gcc.gnu.org/pipermail/libstdc++/2025-May/061653.html The important changes since v3 are: * Fixed and testsed several related overflow issues th