Re: [PATCH v4] bpf: Improvements in CO-RE builtins implementation.

2023-10-27 Thread Cupertino Miranda
Hi David, David Faust writes: > On 10/26/23 08:08, Cupertino Miranda wrote: >> >> Changes from v1: >> - Fixed Davids remarks on initial patch. >> - Fixed mistake with deleted '*'. >> >> Changes from v2: >> - Reversed return value for bpf_const_not_ok_for_debug_p function. > > Hmm.. > >> +sta

Re: [PATCH v4] bpf: Improvements in CO-RE builtins implementation.

2023-10-26 Thread David Faust
On 10/26/23 08:08, Cupertino Miranda wrote: > > Changes from v1: > - Fixed Davids remarks on initial patch. > - Fixed mistake with deleted '*'. > > Changes from v2: > - Reversed return value for bpf_const_not_ok_for_debug_p function. Hmm.. > +static bool > +bpf_const_not_ok_for_debug_p (r

[PATCH v4] bpf: Improvements in CO-RE builtins implementation.

2023-10-26 Thread Cupertino Miranda
Changes from v1: - Fixed Davids remarks on initial patch. - Fixed mistake with deleted '*'. Changes from v2: - Reversed return value for bpf_const_not_ok_for_debug_p function. Changes from v3: - Fixed ICE in two bpf-next tests: - if (!wi->is_lhs) - core_mark_as_access_in