Re: [PATCH v3 6/6] aarch64: Add DLL import/export to AArch64 target

2024-06-25 Thread Christophe Lyon
On Fri, 21 Jun 2024 at 15:51, Richard Sandiford wrote: > > Evgeny Karpov writes: > > Monday, June 10, 2024 7:03 PM > > Richard Sandiford wrote: > > > >> Thanks for the update. Parts 1-5 look good to me. Some minor comments > >> below about part 6: > >> > >> If the TARGET_DLLIMPORT_DECL_ATTRIBU

Re: [PATCH v3 6/6] aarch64: Add DLL import/export to AArch64 target

2024-06-21 Thread Richard Sandiford
Evgeny Karpov writes: > Monday, June 10, 2024 7:03 PM > Richard Sandiford wrote: > >> Thanks for the update. Parts 1-5 look good to me. Some minor comments >> below about part 6: >> >> If the TARGET_DLLIMPORT_DECL_ATTRIBUTES condition can be dropped, the >> series is OK from my POV with that c

Re: [PATCH v3 6/6] aarch64: Add DLL import/export to AArch64 target

2024-06-21 Thread Evgeny Karpov
Monday, June 10, 2024 7:03 PM Richard Sandiford wrote: > Thanks for the update. Parts 1-5 look good to me. Some minor comments > below about part 6: > > If the TARGET_DLLIMPORT_DECL_ATTRIBUTES condition can be dropped, the > series is OK from my POV with that change and with the changes above.

Re: [PATCH v3 6/6] aarch64: Add DLL import/export to AArch64 target

2024-06-10 Thread Richard Sandiford
Thanks for the update. Parts 1-5 look good to me. Some minor comments below about part 6: Evgeny Karpov writes: > This patch reuses the MinGW implementation to enable DLL import/export > functionality for the aarch64-w64-mingw32 target. It also modifies > environment configurations for MinGW. >

[PATCH v3 6/6] aarch64: Add DLL import/export to AArch64 target

2024-06-08 Thread Evgeny Karpov
This patch reuses the MinGW implementation to enable DLL import/export functionality for the aarch64-w64-mingw32 target. It also modifies environment configurations for MinGW. gcc/ChangeLog: * config.gcc: Add winnt-dll.o, which contains the DLL import/export implementation.