Re: [PATCH v3 1/3] or1k: libgcc: initial support for openrisc

2018-10-29 Thread Stafford Horne
On Sun, Oct 28, 2018 at 01:25:54AM +, Richard Henderson wrote: > On 10/27/18 5:37 AM, Stafford Horne wrote: > > +/* Here _init and _fini are empty because .init_array/.fini_array are used > > + exclusively. However, the functions are still needed as required when > > + linking. */ > > +

Re: [PATCH v3 1/3] or1k: libgcc: initial support for openrisc

2018-10-27 Thread Richard Henderson
On 10/27/18 5:37 AM, Stafford Horne wrote: > +/* Here _init and _fini are empty because .init_array/.fini_array are used > + exclusively. However, the functions are still needed as required when > + linking. */ > + .align 4 > + .global _init > + .type _init,@function > +_init: >

Re: [PATCH v3 1/3] or1k: libgcc: initial support for openrisc

2018-10-27 Thread Stafford Horne
Hi, Thanks for the review. On Sat, Oct 27, 2018 at 06:25:04PM -0500, Segher Boessenkool wrote: > Hi! > > On Sat, Oct 27, 2018 at 01:37:00PM +0900, Stafford Horne wrote: > > + /* Given R = X * Y ... */ > > +1: l.sfeq r4, r0 /* while (y != 0) */ > > + l.bf

Re: [PATCH v3 1/3] or1k: libgcc: initial support for openrisc

2018-10-27 Thread Segher Boessenkool
Hi! On Sat, Oct 27, 2018 at 01:37:00PM +0900, Stafford Horne wrote: > + /* Given R = X * Y ... */ > +1: l.sfeq r4, r0 /* while (y != 0) */ > + l.bf2f > + l.andi r5, r4, 1 /* if (y & 1) ... */ Do the extra leading spaces me

[PATCH v3 1/3] or1k: libgcc: initial support for openrisc

2018-10-26 Thread Stafford Horne
-mm-dd Stafford Horne Richard Henderson libgcc/ChangeLog: * config.host: Add OpenRISC support. * config/or1k/*: New. --- libgcc/config.host| 13 ++ libgcc/config/or1k/crti.S | 33 + libgcc/config/or1k/crtn.S | 1 + libg