Re: [PATCH v3 1/2] Factor out static_assert constexpr string extraction for reuse

2024-06-11 Thread Jason Merrill
On 6/5/24 00:45, Andi Kleen wrote: The only semantics changes are slightly more vague error messages to generalize. Just a few nits: +/* Extracting strings from constexpr. */ + +class cexpr_str +{ +public: + cexpr_str (tree message) : message(message) {} Space before paren. ... +/* Get

[PATCH v3 1/2] Factor out static_assert constexpr string extraction for reuse

2024-06-04 Thread Andi Kleen
The only semantics changes are slightly more vague error messages to generalize. gcc/cp/ChangeLog: * cp-tree.h (class cexpr_str): Add. * semantics.cc (finish_static_assert): Convert to use cexpr_str. (cexpr_str::type_check): Extract constexpr string code to here. (