Re: [PATCH v3 09/11] RISC-V: Reapply target_version attribute after target attribute

2024-11-01 Thread Yangyu Chen
On 10/31/24 17:51, Kito Cheng wrote: Could you add a test case for what you try to handle? After carefully reviewing the code, I think this can be dropped in the next revision. The intuition of this patch is to handle both target and target_versions specified in the attributes. But afte

Re: [PATCH v3 09/11] RISC-V: Reapply target_version attribute after target attribute

2024-10-31 Thread Kito Cheng
Could you add a test case for what you try to handle? On Thu, Oct 24, 2024 at 3:15 PM Yangyu Chen wrote: > > To ensure that the target_version attribute is applied after target > attributes. > > gcc/ChangeLog: > > * config/riscv/riscv-target-attr.cc > (riscv_option_valid_attribut

[PATCH v3 09/11] RISC-V: Reapply target_version attribute after target attribute

2024-10-24 Thread Yangyu Chen
To ensure that the target_version attribute is applied after target attributes. gcc/ChangeLog: * config/riscv/riscv-target-attr.cc (riscv_option_valid_attribute_p): Reapply target_version attribute after target attribute --- gcc/config/riscv/riscv-target-attr.cc | 13