Re: [PATCH v3] mklog: handle Signed-off-by, minor cleanup

2023-09-04 Thread Marc via Gcc-patches
Richard Sandiford writes: >> +# this regex matches the first line of the "end" in the initial commit >> message >> +FIRST_LINE_OF_END_RE = re.compile('(?i)^(signed-off-by:|co-authored-by:|#) >> ') > > Personally I think it would be safer to drop the final space in the regexp. > > OK with that

Re: [PATCH v3] mklog: handle Signed-off-by, minor cleanup

2023-09-04 Thread Richard Sandiford via Gcc-patches
Marc Poulhiès via Gcc-patches writes: > Richard Sandiford via Gcc-patches writes: >>> +# this regex matches the first line of the "end" in the initial commit >>> message >>> +FIRST_LINE_OF_END_RE = re.compile('(?i)^(signed-off-by|co-authored-by|#): >>> ') >> >> The current code only requires an

[PATCH v3] mklog: handle Signed-off-by, minor cleanup

2023-09-03 Thread Marc Poulhiès via Gcc-patches
Richard Sandiford via Gcc-patches writes: >> +# this regex matches the first line of the "end" in the initial commit >> message >> +FIRST_LINE_OF_END_RE = re.compile('(?i)^(signed-off-by|co-authored-by|#): ') > > The current code only requires an initial "#", rather than an initial "#: ". > Is th

[PATCH v3] mklog: handle Signed-off-by, minor cleanup

2023-08-02 Thread Marc Poulhiès via Gcc-patches
Consider Signed-off-by lines as part of the ending of the initial commit to avoid having these in the middle of the log when the changelog part is injected after. This is particularly usefull with: $ git gcc-commit-mklog --amend -s that can be used to create the changelog and add the Signed-off