Re: [PATCH v3] ipa-inline: Add target info into fn summary [PR102059]

2021-09-20 Thread Kewen.Lin via Gcc-patches
Hi Martin, Thanks for the review. on 2021/9/18 下午7:31, Martin Jambor wrote: > Hi, > > On Fri, Sep 17 2021, Segher Boessenkool wrote: >> On Fri, Sep 17, 2021 at 05:42:38PM +0800, Kewen.Lin wrote: >>> Against v2 [2], this v3 addressed Martin's review comments: >>> - Replace HWI auto_vec with uns

Re: [PATCH v3] ipa-inline: Add target info into fn summary [PR102059]

2021-09-20 Thread Kewen.Lin via Gcc-patches
Hi Segher, Thanks for the review! on 2021/9/17 下午10:14, Segher Boessenkool wrote: > On Fri, Sep 17, 2021 at 05:42:38PM +0800, Kewen.Lin wrote: >> Against v2 [2], this v3 addressed Martin's review comments: >> - Replace HWI auto_vec with unsigned int for target_info >> to avoid overkill (als

Re: [PATCH v3] ipa-inline: Add target info into fn summary [PR102059]

2021-09-18 Thread Martin Jambor
Hi, On Fri, Sep 17 2021, Segher Boessenkool wrote: > On Fri, Sep 17, 2021 at 05:42:38PM +0800, Kewen.Lin wrote: >> Against v2 [2], this v3 addressed Martin's review comments: >> - Replace HWI auto_vec with unsigned int for target_info >> to avoid overkill (also Segher's comments), adjust som

Re: [PATCH v3] ipa-inline: Add target info into fn summary [PR102059]

2021-09-17 Thread Segher Boessenkool
On Fri, Sep 17, 2021 at 05:42:38PM +0800, Kewen.Lin wrote: > Against v2 [2], this v3 addressed Martin's review comments: > - Replace HWI auto_vec with unsigned int for target_info > to avoid overkill (also Segher's comments), adjust some > places need to be updated for this change. I'd h

Re: [PATCH v3] ipa-inline: Add target info into fn summary [PR102059]

2021-09-17 Thread Martin Jambor
Hi, On Fri, Sep 17 2021, Kewen.Lin wrote: > [...] > > Against v2 [2], this v3 addressed Martin's review comments: > - Replace HWI auto_vec with unsigned int for target_info > to avoid overkill (also Segher's comments), adjust some > places need to be updated for this change. > - Annota

[PATCH v3] ipa-inline: Add target info into fn summary [PR102059]

2021-09-17 Thread Kewen.Lin via Gcc-patches
Hi! Power ISA 2.07 (Power8) introduces transactional memory feature but ISA3.1 (Power10) removes it. It exposes one troublesome issue as PR102059 shows. Users define some function with target pragma cpu=power10 then it calls one function with attribute always_inline which inherits command line o