RE: [PATCH v3] aarch64: Fine-grained policies to control ldp-stp formation.

2023-09-26 Thread Kyrylo Tkachov
> -Original Message- > From: Kyrylo Tkachov > Sent: Tuesday, September 26, 2023 9:36 AM > To: Manos Anagnostakis ; gcc- > patc...@gcc.gnu.org > Cc: Philipp Tomsich ; Andrew Pinski > > Subject: RE: [PATCH v3] aarch64: Fine-grained policies to control ldp-stp &g

RE: [PATCH v3] aarch64: Fine-grained policies to control ldp-stp formation.

2023-09-26 Thread Kyrylo Tkachov
ilipp Tomsich ; Kyrylo Tkachov ; Andrew Pinski Subject: Re: [PATCH v3] aarch64: Fine-grained policies to control ldp-stp formation. Thank you Andrew for the input. I've prepared a patch using --param with enum, which seems a more suitable approach to me as strings are more descriptive as

RE: [PATCH v3] aarch64: Fine-grained policies to control ldp-stp formation.

2023-09-26 Thread Kyrylo Tkachov
> -Original Message- > From: Andrew Pinski > Sent: Monday, September 25, 2023 9:05 PM > To: Philipp Tomsich > Cc: Manos Anagnostakis ; gcc- > patc...@gcc.gnu.org; Kyrylo Tkachov > Subject: Re: [PATCH v3] aarch64: Fine-grained policies to control ldp-stp > for

Re: [PATCH v3] aarch64: Fine-grained policies to control ldp-stp formation.

2023-09-25 Thread Manos Anagnostakis
Thank you Andrew for the input. I've prepared a patch using --param with enum, which seems a more suitable approach to me as strings are more descriptive as well. The current patch needed an adjustment on how to call the parsing functions to match the compiler coding style. Both are bootstrapped

Re: [PATCH v3] aarch64: Fine-grained policies to control ldp-stp formation.

2023-09-25 Thread Andrew Pinski
On Mon, Sep 25, 2023 at 1:04 PM Andrew Pinski wrote: > > On Mon, Sep 25, 2023 at 12:59 PM Philipp Tomsich > wrote: > > > > On Mon, 25 Sept 2023 at 21:54, Andrew Pinski wrote: > > > > > > On Mon, Sep 25, 2023 at 12:50 PM Manos Anagnostakis > > > wrote: > > > > > > > > This patch implements the f

Re: [PATCH v3] aarch64: Fine-grained policies to control ldp-stp formation.

2023-09-25 Thread Andrew Pinski
On Mon, Sep 25, 2023 at 12:59 PM Philipp Tomsich wrote: > > On Mon, 25 Sept 2023 at 21:54, Andrew Pinski wrote: > > > > On Mon, Sep 25, 2023 at 12:50 PM Manos Anagnostakis > > wrote: > > > > > > This patch implements the following TODO in gcc/config/aarch64/aarch64.cc > > > to provide the reques

Re: [PATCH v3] aarch64: Fine-grained policies to control ldp-stp formation.

2023-09-25 Thread Manos Anagnostakis
Hello Andrew, what you describe was my previous version, but @Kyrylo Tkachov prompted me to use -param. Thank you for taking a look anyway! Manos Anagnostakis | Compiler Engineer | E: manos.anagnosta...@vrull.eu VRULL GmbH | Beatrixgasse 32 1030 Vienna | W: www.vrull.eu Στις Δευ 25 Σεπ 2023,

Re: [PATCH v3] aarch64: Fine-grained policies to control ldp-stp formation.

2023-09-25 Thread Philipp Tomsich
On Mon, 25 Sept 2023 at 21:54, Andrew Pinski wrote: > > On Mon, Sep 25, 2023 at 12:50 PM Manos Anagnostakis > wrote: > > > > This patch implements the following TODO in gcc/config/aarch64/aarch64.cc > > to provide the requested behaviour for handling ldp and stp: > > > > /* Allow the tuning str

Re: [PATCH v3] aarch64: Fine-grained policies to control ldp-stp formation.

2023-09-25 Thread Andrew Pinski
On Mon, Sep 25, 2023 at 12:50 PM Manos Anagnostakis wrote: > > This patch implements the following TODO in gcc/config/aarch64/aarch64.cc > to provide the requested behaviour for handling ldp and stp: > > /* Allow the tuning structure to disable LDP instruction formation > from combining ins

[PATCH v3] aarch64: Fine-grained policies to control ldp-stp formation.

2023-09-25 Thread Manos Anagnostakis
This patch implements the following TODO in gcc/config/aarch64/aarch64.cc to provide the requested behaviour for handling ldp and stp: /* Allow the tuning structure to disable LDP instruction formation from combining instructions (e.g., in peephole2). TODO: Implement fine-grained tunin