RE: [PATCH v3] RISCV: Add -m(no)-omit-leaf-frame-pointer support.

2023-08-02 Thread Li, Pan2 via Gcc-patches
Committed, thanks Jeff and Kito. Pan -Original Message- From: Li, Pan2 Sent: Thursday, August 3, 2023 2:17 PM To: Jeff Law ; Wang, Yanzhang ; Kito Cheng Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; kito.ch...@sifive.com Subject: RE: [PATCH v3] RISCV: Add -m(no)-omit-leaf-frame

RE: [PATCH v3] RISCV: Add -m(no)-omit-leaf-frame-pointer support.

2023-08-02 Thread Li, Pan2 via Gcc-patches
(no)-omit-leaf-frame-pointer support. On 8/1/23 19:51, Wang, Yanzhang wrote: > Hi Jeff, > > Do you have any further comments about this patch ? I thought we covered this in the meeting earlier this week. This is fine for the trunk. If you or Pan doesn't get around to committi

Re: [PATCH v3] RISCV: Add -m(no)-omit-leaf-frame-pointer support.

2023-08-02 Thread Jeff Law via Gcc-patches
On 8/1/23 19:51, Wang, Yanzhang wrote: Hi Jeff, Do you have any further comments about this patch ? I thought we covered this in the meeting earlier this week. This is fine for the trunk. If you or Pan doesn't get around to committing it before I start my day tomorrow, I'll go ahead and

RE: [PATCH v3] RISCV: Add -m(no)-omit-leaf-frame-pointer support.

2023-08-01 Thread Wang, Yanzhang via Gcc-patches
ve.com; > Li, Pan2 > Subject: Re: [PATCH v3] RISCV: Add -m(no)-omit-leaf-frame-pointer support. > > > > On 7/20/23 21:49, Kito Cheng wrote: > > LGTM, I think long jump is another issue and making ra become a fixed > > register will escalate to an ABI issue, so that should

Re: [PATCH v3] RISCV: Add -m(no)-omit-leaf-frame-pointer support.

2023-07-20 Thread Jeff Law via Gcc-patches
On 7/20/23 21:49, Kito Cheng wrote: LGTM, I think long jump is another issue and making ra become a fixed register will escalate to an ABI issue, so that should not be a blocker for this patch. I'll take a look tomorrow, but I'm supportive of what Yanzhang is trying to do in principle. I've

Re: [PATCH v3] RISCV: Add -m(no)-omit-leaf-frame-pointer support.

2023-07-20 Thread Kito Cheng via Gcc-patches
LGTM, I think long jump is another issue and making ra become a fixed register will escalate to an ABI issue, so that should not be a blocker for this patch. On Tue, Jul 18, 2023 at 4:10 PM yanzhang.wang--- via Gcc-patches wrote: > > From: Yanzhang Wang > > gcc/ChangeLog: > > * config/ri

[PATCH v3] RISCV: Add -m(no)-omit-leaf-frame-pointer support.

2023-07-18 Thread yanzhang.wang--- via Gcc-patches
From: Yanzhang Wang gcc/ChangeLog: * config/riscv/riscv.cc (riscv_save_reg_p): Save ra for leaf when enabling -mno-omit-leaf-frame-pointer (riscv_option_override): Override omit-frame-pointer. (riscv_frame_pointer_required): Save s0 for non-leaf function