Re: [PATCH v3] PR libitm/61164: use always_inline consistently

2014-09-29 Thread Torvald Riegel
On Mon, 2014-09-29 at 17:38 +0200, Jakub Jelinek wrote: > On Mon, Sep 29, 2014 at 05:35:24PM +0200, Torvald Riegel wrote: > > On Mon, 2014-09-29 at 16:53 +0400, Gleb Fotengauer-Malinovskiy wrote: > > > -#undef __always_inline > > > -#define __always_inline __attribute__((always_inline)) > > > +#de

Re: [PATCH v3] PR libitm/61164: use always_inline consistently

2014-09-29 Thread Jakub Jelinek
On Mon, Sep 29, 2014 at 05:35:24PM +0200, Torvald Riegel wrote: > On Mon, 2014-09-29 at 16:53 +0400, Gleb Fotengauer-Malinovskiy wrote: > > -#undef __always_inline > > -#define __always_inline __attribute__((always_inline)) > > +#define __libitm_always_inline inline __attribute__((always_inline))

Re: [PATCH v3] PR libitm/61164: use always_inline consistently

2014-09-29 Thread Torvald Riegel
On Mon, 2014-09-29 at 16:53 +0400, Gleb Fotengauer-Malinovskiy wrote: > -#undef __always_inline > -#define __always_inline __attribute__((always_inline)) > +#define __libitm_always_inline inline __attribute__((always_inline)) The previous code seems to work in libstdc++. I believe that eventuall

Re: [PATCH v3] PR libitm/61164: use always_inline consistently

2014-09-29 Thread Jakub Jelinek
On Mon, Sep 29, 2014 at 04:53:26PM +0400, Gleb Fotengauer-Malinovskiy wrote: > 2014-09-27 Gleb Fotengauer-Malinovskiy Two spaces around name on each side. > > libitm/ > > PR libitm/61164 > * local_atomic: Rename __always_inline to __libitm_always_inline > to eliminate glibc ma

Re: [PATCH v3] PR libitm/61164: use always_inline consistently

2014-09-29 Thread Gleb Fotengauer-Malinovskiy
2014-09-27 Gleb Fotengauer-Malinovskiy libitm/ PR libitm/61164 * local_atomic: Rename __always_inline to __libitm_always_inline to eliminate glibc macro redefinition. (__libitm_always_inline): Add inline. (__calculate_memory_order): Remove inline.