Re: [PATCH v3] Fix alignment for local variable [PR90811]

2020-04-09 Thread Kito Cheng
Hi Richard: > Please skip vars with DECL_USER_ALIGN. I was consider to skip DECL_USER_ALIGN, but Jakub think it shouldn't skip in other patch review[1] (related to this patch), because it's minimum alignment not restricted alignment[2] [1] https://gcc.gnu.org/pipermail/gcc-patches/2020-March/542

Re: [PATCH v3] Fix alignment for local variable [PR90811]

2020-04-09 Thread Richard Biener via Gcc-patches
On Wed, Apr 8, 2020 at 7:13 PM Kito Cheng wrote: > > ping > > On Tue, Mar 31, 2020 at 4:33 PM Kito Cheng wrote: > > > > - The alignment for local variable was adjust during > > estimate_stack_frame_size, > >however it seems wrong spot to adjust that, expand phase will adjust that > >but

Re: [PATCH v3] Fix alignment for local variable [PR90811]

2020-04-08 Thread Kito Cheng
ping On Tue, Mar 31, 2020 at 4:33 PM Kito Cheng wrote: > > - The alignment for local variable was adjust during > estimate_stack_frame_size, >however it seems wrong spot to adjust that, expand phase will adjust that >but it little too late to some gimple optimization, which rely on cert

[PATCH v3] Fix alignment for local variable [PR90811]

2020-03-31 Thread Kito Cheng
- The alignment for local variable was adjust during estimate_stack_frame_size, however it seems wrong spot to adjust that, expand phase will adjust that but it little too late to some gimple optimization, which rely on certain target hooks need to check alignment, forwprop is an example