Re: [PATCH v2 7/7] Add a unit test for random access in the file cache

2025-02-02 Thread Andi Kleen
On Sun, Feb 02, 2025 at 09:35:52PM -0800, Andi Kleen wrote: > > Patch 7 is OK otherwise, and I'm taking a look at the rest of the > > patches now; thanks. > > Any comments on the other patches? nm. I see you already commented. somehow i missed that. -Andi

Re: [PATCH v2 7/7] Add a unit test for random access in the file cache

2025-02-02 Thread Andi Kleen
> Patch 7 is OK otherwise, and I'm taking a look at the rest of the > patches now; thanks. Any comments on the other patches? Thanks, -Andi

Re: [PATCH v2 7/7] Add a unit test for random access in the file cache

2025-01-27 Thread David Malcolm
On Sat, 2025-01-25 at 23:31 -0800, Andi Kleen wrote: > From: Andi Kleen Thanks for writing the test case! Some nitpicks... > > gcc/ChangeLog: > > * input.cc (check_line): New. > (test_replacement): New function to test line caching. > (input_cc_tests): Call test_replacement

Re: [PATCH v2 7/7] Add a unit test for random access in the file cache

2025-01-27 Thread David Malcolm
On Mon, 2025-01-27 at 11:25 -0500, David Malcolm wrote: > On Sat, 2025-01-25 at 23:31 -0800, Andi Kleen wrote: > > From: Andi Kleen > > Thanks for writing the test case! > > Some nitpicks... > > > > > > gcc/ChangeLog: > > > > * input.cc (check_line): New. > > (test_replacement): New

[PATCH v2 7/7] Add a unit test for random access in the file cache

2025-01-25 Thread Andi Kleen
From: Andi Kleen gcc/ChangeLog: * input.cc (check_line): New. (test_replacement): New function to test line caching. (input_cc_tests): Call test_replacement --- gcc/input.cc | 46 ++ 1 file changed, 46 insertions(+) diff --git