Re: [PATCH v2 6/8] gcn: Add else operand to masked loads.

2024-10-29 Thread Andrew Stubbs
On 29/10/2024 09:39, Andrew Stubbs wrote: On 28/10/2024 20:03, Robin Dapp wrote: I'm not sure how this is different to just deleting the zero-initializer, which is what I already tested and found some random behaviour? The difference is in the else-operand predicate.  So unless there are more

Re: [PATCH v2 6/8] gcn: Add else operand to masked loads.

2024-10-29 Thread Andrew Stubbs
On 28/10/2024 20:03, Robin Dapp wrote: I'm not sure how this is different to just deleting the zero-initializer, which is what I already tested and found some random behaviour? The difference is in the else-operand predicate. So unless there are more bugs we should only have added VCOND_EXPRs

Re: [PATCH v2 6/8] gcn: Add else operand to masked loads.

2024-10-29 Thread Richard Biener
On Tue, 29 Oct 2024, Andrew Stubbs wrote: > On 28/10/2024 20:03, Robin Dapp wrote: > >> I'm not sure how this is different to just deleting the > >> zero-initializer, which is what I already tested and found some random > >> behaviour? > > > > The difference is in the else-operand predicate. So

Re: [PATCH v2 6/8] gcn: Add else operand to masked loads.

2024-10-28 Thread Robin Dapp
> I'm not sure how this is different to just deleting the > zero-initializer, which is what I already tested and found some random > behaviour? The difference is in the else-operand predicate. So unless there are more bugs we should only have added VCOND_EXPRs for the cases where they are absol

Re: [PATCH v2 6/8] gcn: Add else operand to masked loads.

2024-10-22 Thread Andrew Stubbs
On 18/10/2024 15:22, Robin Dapp wrote: This patch adds an undefined else operand to the masked loads. @@ -4027,7 +4025,8 @@ (define_expand "mask_gather_load" (match_operand: 2 "register_operand") (match_operand 3 "immediate_operand") (match_operand:SI 4 "gcn_alu_operand") - (

[PATCH v2 6/8] gcn: Add else operand to masked loads.

2024-10-18 Thread Robin Dapp
This patch adds an undefined else operand to the masked loads. gcc/ChangeLog: * config/gcn/predicates.md (maskload_else_operand): New predicate. * config/gcn/gcn-valu.md: Use new predicate. --- gcc/config/gcn/gcn-valu.md | 12 gcc/config/gcn/predicates.md |