Re: [PATCH v2 3/4] RISC-V: Add .note.gnu.property for ZICFILP and ZICFISS ISA extension

2025-01-15 Thread Monk Chiang
I agree with your point of view. Currently, there is a proposal under discussion, and everyone tends to favor using GNU Properties. https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/417 On Wed, Jan 15, 2025 at 6:16 AM Greg McGary wrote: > The RISCV psABI already specifies ELF attributes

Re: [PATCH v2 3/4] RISC-V: Add .note.gnu.property for ZICFILP and ZICFISS ISA extension

2025-01-14 Thread Greg McGary
The RISCV psABI already specifies ELF attributes as the mechanism for attaching feature bits to object files, so it is neither necessary nor desirable to add another. https://github.com/riscv-non-isa/riscv-elf-psabi-doc/blob/master/riscv-elf.adoc#attributes G On Tue, Jan 14, 2025 at 3:07 PM Greg

Re: [PATCH v2 3/4] RISC-V: Add .note.gnu.property for ZICFILP and ZICFISS ISA extension

2025-01-14 Thread Greg McGary
On Mon, Jan 13, 2025 at 1:02 AM Monk Chiang wrote: > > * gcc/config/riscv/riscv.cc > (riscv_file_end_indicate_exec_stack): Add .note.gnu.property. > > * libgcc/config/riscv/riscv-asm.h: Add GNU_PROPERTY for ZICFILP, > ZICFISS. > ELF attributes (.riscv.attributes

[PATCH v2 3/4] RISC-V: Add .note.gnu.property for ZICFILP and ZICFISS ISA extension

2025-01-13 Thread Monk Chiang
gcc/ChangeLog: * gcc/config/riscv/riscv.cc (riscv_file_end_indicate_exec_stack): Add .note.gnu.property. * gcc/config/riscv/linux.h (TARGET_ASM_FILE_END): Define. libgcc/ChangeLog: * libgcc/config/riscv/crti.S: Add lpad instructions. * libgcc/config/riscv/cr