Re: [PATCH v2 13/13] Add hook for modifying debug info for address spaces

2015-10-22 Thread Ulrich Weigand
Richard Henderson wrote: > So you would recommend continuing to use address_class for these x86 segments? Yes, I think so. As far as I can see, this would simply require to define two address_class values to correspond to __seg_fs and __seg_gs. (These choices should best be documented in the pl

Re: [PATCH v2 13/13] Add hook for modifying debug info for address spaces

2015-10-21 Thread Richard Henderson
On 10/21/2015 06:19 AM, Ulrich Weigand wrote: Richard Henderson wrote: +@deftypefn {Target Hook} int TARGET_ADDR_SPACE_DEBUG (addr_space_t @var{as}) +Define this to define how the address space is encoded in dwarf. +The result, @var{r}, should be positive to indicate +@code{DW_AT_address_class

Re: [PATCH v2 13/13] Add hook for modifying debug info for address spaces

2015-10-21 Thread H.J. Lu
On Wed, Oct 21, 2015 at 10:49 AM, Richard Henderson wrote: > On 10/21/2015 07:23 AM, H.J. Lu wrote: >> >> We can define them as 93 and 94. 50-92 were used for other registers >> before and have been deprecated now. But some old tools may >> still use them. > > The i386 psABI draft is at https:

Re: [PATCH v2 13/13] Add hook for modifying debug info for address spaces

2015-10-21 Thread Richard Henderson
On 10/21/2015 07:23 AM, H.J. Lu wrote: We can define them as 93 and 94. 50-92 were used for other registers before and have been deprecated now. But some old tools may still use them. Thanks. I'll update the patch. r~

Re: [PATCH v2 13/13] Add hook for modifying debug info for address spaces

2015-10-21 Thread H.J. Lu
On Wed, Oct 21, 2015 at 10:17 AM, Richard Henderson wrote: > On 10/21/2015 04:53 AM, H.J. Lu wrote: >> >> On Tue, Oct 20, 2015 at 2:27 PM, Richard Henderson wrote: >>> >>> --- >>> gcc/config/i386/i386.c | 21 + >>> gcc/doc/tm.texi| 7 +++ >>> gcc/doc/tm.texi.i

Re: [PATCH v2 13/13] Add hook for modifying debug info for address spaces

2015-10-21 Thread Richard Henderson
On 10/21/2015 04:53 AM, H.J. Lu wrote: On Tue, Oct 20, 2015 at 2:27 PM, Richard Henderson wrote: --- gcc/config/i386/i386.c | 21 + gcc/doc/tm.texi| 7 +++ gcc/doc/tm.texi.in | 2 ++ gcc/dwarf2out.c| 48 +

Re: [PATCH v2 13/13] Add hook for modifying debug info for address spaces

2015-10-21 Thread Ulrich Weigand
Richard Henderson wrote: > +@deftypefn {Target Hook} int TARGET_ADDR_SPACE_DEBUG (addr_space_t @var{as}) > +Define this to define how the address space is encoded in dwarf. > +The result, @var{r}, should be positive to indicate > +@code{DW_AT_address_class @var{r}} should be emitted; or negative >

Re: [PATCH v2 13/13] Add hook for modifying debug info for address spaces

2015-10-21 Thread H.J. Lu
On Tue, Oct 20, 2015 at 2:27 PM, Richard Henderson wrote: > --- > gcc/config/i386/i386.c | 21 + > gcc/doc/tm.texi| 7 +++ > gcc/doc/tm.texi.in | 2 ++ > gcc/dwarf2out.c| 48 +--- > gcc/target.def |

Re: [PATCH v2 13/13] Add hook for modifying debug info for address spaces

2015-10-21 Thread Jeff Law
On 10/20/2015 03:27 PM, Richard Henderson wrote: --- gcc/config/i386/i386.c | 21 + gcc/doc/tm.texi| 7 +++ gcc/doc/tm.texi.in | 2 ++ gcc/dwarf2out.c| 48 +--- gcc/target.def | 10 ++

[PATCH v2 13/13] Add hook for modifying debug info for address spaces

2015-10-20 Thread Richard Henderson
--- gcc/config/i386/i386.c | 21 + gcc/doc/tm.texi| 7 +++ gcc/doc/tm.texi.in | 2 ++ gcc/dwarf2out.c| 48 +--- gcc/target.def | 10 ++ gcc/targhooks.c| 8 gcc/targhooks.h