Re: [PATCH v2 10/14] Support for 64-bit location_t: gimple parts

2024-11-26 Thread Jakub Jelinek
On Mon, Nov 25, 2024 at 09:57:16AM +0100, Richard Biener wrote: > On Sun, Nov 24, 2024 at 7:22 PM Hans-Peter Nilsson wrote: > > > > On Sat, 16 Nov 2024, Lewis Hyatt wrote: > > > The size of struct gimple increases by 8 bytes with the change in size of > > > location_t from 32- to 64-bit > > > > Ha

Re: [PATCH v2 10/14] Support for 64-bit location_t: gimple parts

2024-11-25 Thread Richard Biener
On Sun, Nov 24, 2024 at 7:22 PM Hans-Peter Nilsson wrote: > > On Sat, 16 Nov 2024, Lewis Hyatt wrote: > > The size of struct gimple increases by 8 bytes with the change in size of > > location_t from 32- to 64-bit > > Half-way scrolling through the patches, this seems a good time > for a possibly

Re: [PATCH v2 10/14] Support for 64-bit location_t: gimple parts

2024-11-24 Thread Hans-Peter Nilsson
On Sat, 16 Nov 2024, Lewis Hyatt wrote: > The size of struct gimple increases by 8 bytes with the change in size of > location_t from 32- to 64-bit Half-way scrolling through the patches, this seems a good time for a possibly disruptive comment from the side-line: ;-) For the size-critical types

Re: [PATCH v2 10/14] Support for 64-bit location_t: gimple parts

2024-11-20 Thread Richard Biener
On Tue, Nov 19, 2024 at 4:43 PM Lewis Hyatt wrote: > > On Tue, Nov 19, 2024 at 10:06 AM Richard Biener > wrote: > > > > On Sun, Nov 17, 2024 at 4:30 AM Lewis Hyatt wrote: > > > > > > The size of struct gimple increases by 8 bytes with the change in size of > > > location_t from 32- to 64-bit; ad

Re: [PATCH v2 10/14] Support for 64-bit location_t: gimple parts

2024-11-19 Thread Richard Biener
On Sun, Nov 17, 2024 at 4:30 AM Lewis Hyatt wrote: > > The size of struct gimple increases by 8 bytes with the change in size of > location_t from 32- to 64-bit; adjust the WORD markings in the comments > accordingly. It seems that most of the WORD markings were off by one already, > probably not

Re: [PATCH v2 10/14] Support for 64-bit location_t: gimple parts

2024-11-19 Thread Lewis Hyatt
On Tue, Nov 19, 2024 at 10:06 AM Richard Biener wrote: > > On Sun, Nov 17, 2024 at 4:30 AM Lewis Hyatt wrote: > > > > The size of struct gimple increases by 8 bytes with the change in size of > > location_t from 32- to 64-bit; adjust the WORD markings in the comments > > accordingly. It seems tha

[PATCH v2 10/14] Support for 64-bit location_t: gimple parts

2024-11-16 Thread Lewis Hyatt
The size of struct gimple increases by 8 bytes with the change in size of location_t from 32- to 64-bit; adjust the WORD markings in the comments accordingly. It seems that most of the WORD markings were off by one already, probably not having been updated after a previous reduction in the size of