Re: [PATCH v2 1/6] Convert symtab, cgraph and varpool nodes into a real class hierarchy

2013-09-18 Thread Richard Biener
On Wed, Sep 18, 2013 at 9:24 AM, Jan Hubicka wrote: >> > > +cgraph_node *cgn = static_cast (x); >> > > +gt_ggc_m_11cgraph_edge (cgn->callers); >> > > +gt_ggc_m_11cgraph_node (cgn->origin); >> > > +gt_ggc_m_11cgraph_node (cgn->nested); >> > > +

Re: [PATCH v2 1/6] Convert symtab, cgraph and varpool nodes into a real class hierarchy

2013-09-18 Thread Jan Hubicka
> > > +cgraph_node *cgn = static_cast (x); > > > +gt_ggc_m_11cgraph_edge (cgn->callers); > > > +gt_ggc_m_11cgraph_node (cgn->origin); > > > +gt_ggc_m_11cgraph_node (cgn->nested); > > > +gt_ggc_m_11cgraph_node (cgn->next_nested); > > > +

Re: [PATCH v2 1/6] Convert symtab, cgraph and varpool nodes into a real class hierarchy

2013-09-17 Thread David Malcolm
On Tue, 2013-09-10 at 15:34 +0200, Jan Hubicka wrote: Thanks for reviewing this, and sorry for the late response (I lost most of last week to illness). Some questions inline below... > > This patch is the handwritten part of the conversion of these types > > to C++; it requires the followup patc

Re: [PATCH v2 1/6] Convert symtab, cgraph and varpool nodes into a real class hierarchy

2013-09-10 Thread Jan Hubicka
> This patch is the handwritten part of the conversion of these types > to C++; it requires the followup patch, which is autogenerated. > > It converts: > struct GTY(()) symtab_node_base > to: > class GTY((user)) symtab_node_base > > and converts: > struct GTY(()) cgraph_node > to: > stru

Re: [PATCH v2 1/6] Convert symtab, cgraph and varpool nodes into a real class hierarchy

2013-09-10 Thread Richard Biener
On Mon, Sep 9, 2013 at 9:32 PM, David Malcolm wrote: > This patch is the handwritten part of the conversion of these types > to C++; it requires the followup patch, which is autogenerated. > > It converts: > struct GTY(()) symtab_node_base > to: > class GTY((user)) symtab_node_base > > and con

[PATCH v2 1/6] Convert symtab, cgraph and varpool nodes into a real class hierarchy

2013-09-09 Thread David Malcolm
This patch is the handwritten part of the conversion of these types to C++; it requires the followup patch, which is autogenerated. It converts: struct GTY(()) symtab_node_base to: class GTY((user)) symtab_node_base and converts: struct GTY(()) cgraph_node to: struct GTY((user)) cgraph_no