Re: [PATCH v2 1/2] MIPS: use mips_isa enum instead hardcoded numbers

2021-09-16 Thread Martin Liška
On 9/15/21 15:08, Martin Liška wrote: Hello. I noticed the change likely caused the following failure when building x86_64-linux-gnu cross compiler: g++  -fno-PIE -c  -DIN_GCC_FRONTEND -DIN_GCC_FRONTEND -g   -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE   -fno-exceptions -fno-rtti -fasynchronous-unwi

Re: [PATCH v2 1/2] MIPS: use mips_isa enum instead hardcoded numbers

2021-09-15 Thread Martin Liška
Hello. I noticed the change likely caused the following failure when building x86_64-linux-gnu cross compiler: g++ -fno-PIE -c -DIN_GCC_FRONTEND -DIN_GCC_FRONTEND -g -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwri

Re: [PATCH v2 1/2] MIPS: use mips_isa enum instead hardcoded numbers

2021-08-30 Thread Jeff Law via Gcc-patches
On 8/30/2021 12:52 AM, Xi Ruoyao via Gcc-patches wrote: These two patches look good to me. Still, need a maintainer's approval. Consider them approved. Thanks, Jeff

Re: [PATCH v2 1/2] MIPS: use mips_isa enum instead hardcoded numbers

2021-08-29 Thread Xi Ruoyao via Gcc-patches
These two patches look good to me. Still, need a maintainer's approval. On Sun, 2021-08-29 at 22:59 -0400, YunQiang Su wrote: > Currently mips-cpu.defs, mips.h, netbsd.h and config.gcc are > using hardcoded numbers for isa level. > > Let's replace them with more readable enum mips_isa. > > gcc/

[PATCH v2 1/2] MIPS: use mips_isa enum instead hardcoded numbers

2021-08-29 Thread YunQiang Su
Currently mips-cpu.defs, mips.h, netbsd.h and config.gcc are using hardcoded numbers for isa level. Let's replace them with more readable enum mips_isa. gcc/ChangeLog: * config/mips/mips.h (struct mips_cpu_info): define enum mips_isa; use enum instead of int for 'isa' member.