Re: Re: [PATCH v2 1/1] RISC-V: Support BF16 interfaces in libgcc

2024-08-15 Thread Xiao Zeng
2024-08-13 15:53  Jakub Jelinek wrote: > >On Tue, Aug 13, 2024 at 11:14:47AM +0800, Xiao Zeng wrote: >> Thank you very much for the in-depth discussion between Jakub Jelinek and >> jeff. >> My knowledge is narrow, and I am not familiar with architectures other than >> RISCV. >> At the same time,

Re: Re: [PATCH v2 1/1] RISC-V: Support BF16 interfaces in libgcc

2024-08-13 Thread Jakub Jelinek
On Tue, Aug 13, 2024 at 11:14:47AM +0800, Xiao Zeng wrote: > Thank you very much for the in-depth discussion between Jakub Jelinek and > jeff. > My knowledge is narrow, and I am not familiar with architectures other than > RISCV. > At the same time, my understanding of libraries such as libc and

Re: Re: [PATCH v2 1/1] RISC-V: Support BF16 interfaces in libgcc

2024-08-12 Thread Xiao Zeng
2024-08-07 23:15  Jeff Law wrote: > > > >On 8/7/24 8:55 AM, Jakub Jelinek wrote: >> On Wed, Aug 07, 2024 at 08:46:11AM -0600, Jeff Law wrote: >>> >>> >>> On 8/7/24 1:16 AM, Jakub Jelinek wrote: >>> This looks all wrong to me. On all the other targets that already do support __b

Re: [PATCH v2 1/1] RISC-V: Support BF16 interfaces in libgcc

2024-08-07 Thread Jeff Law
On 8/7/24 8:55 AM, Jakub Jelinek wrote: On Wed, Aug 07, 2024 at 08:46:11AM -0600, Jeff Law wrote: On 8/7/24 1:16 AM, Jakub Jelinek wrote: This looks all wrong to me. On all the other targets that already do support __bf16 type it is a storage only type, so all arithmetics on it is expec

Re: [PATCH v2 1/1] RISC-V: Support BF16 interfaces in libgcc

2024-08-07 Thread Jakub Jelinek
On Wed, Aug 07, 2024 at 08:46:11AM -0600, Jeff Law wrote: > > > On 8/7/24 1:16 AM, Jakub Jelinek wrote: > > > > > This looks all wrong to me. > > > > On all the other targets that already do support __bf16 type it is a storage > > only type, so all arithmetics on it is expected to be done on f

Re: [PATCH v2 1/1] RISC-V: Support BF16 interfaces in libgcc

2024-08-07 Thread Jeff Law
On 8/7/24 1:16 AM, Jakub Jelinek wrote: This looks all wrong to me. On all the other targets that already do support __bf16 type it is a storage only type, so all arithmetics on it is expected to be done on float, not in __bf16. RISC-V has (via extensions) degrees of arithmetic/conversion s

Re: [PATCH v2 1/1] RISC-V: Support BF16 interfaces in libgcc

2024-08-07 Thread Jakub Jelinek
On Wed, Aug 07, 2024 at 11:13:51AM +0800, Xiao Zeng wrote: > gcc/ChangeLog: > > * builtin-types.def (BT_COMPLEX_BFLOAT16): Support BF16 node. > (BT_BFLOAT16_PTR): Ditto. > (BT_FN_BFLOAT16): New. > (BT_FN_BFLOAT16_BFLOAT16): Ditto. > (BT_FN_COMPLEX_BFLOAT16_COMPLEX_BFL

Re: [PATCH v2 1/1] RISC-V: Support BF16 interfaces in libgcc

2024-08-06 Thread Xiao Zeng
2024-08-07 11:13  Xiao Zeng wrote: The existing test cases 'gcc.dg/portal/float16 complex.c' for gcc are already good, so no new test cases were added. Of course, more test cases are always good, and if necessary, I will supplement the test cases. > >gcc/ChangeLog: > > * builtin-types.def

[PATCH v2 1/1] RISC-V: Support BF16 interfaces in libgcc

2024-08-06 Thread Xiao Zeng
gcc/ChangeLog: * builtin-types.def (BT_COMPLEX_BFLOAT16): Support BF16 node. (BT_BFLOAT16_PTR): Ditto. (BT_FN_BFLOAT16): New. (BT_FN_BFLOAT16_BFLOAT16): Ditto. (BT_FN_COMPLEX_BFLOAT16_COMPLEX_BFLOAT16): Ditto. (BT_FN_BFLOAT16_COMPLEX_BFLOAT16): Ditto