Re: [PATCH v2 1/1] C: Support Function multiversionsing in the C front end

2024-11-04 Thread Alfie Richards
Hi Joseph, Thank you for the review and nice to meet you. @@ -3191,6 +3240,14 @@ duplicate_decls (tree newdecl, tree olddecl) return false; } + /* If both new and old are Function Multi Versioned functions then they are + not duplicates. */ + if (TREE_CODE (newdecl) == FUNCTION_

Re: [PATCH v2 1/1] C: Support Function multiversionsing in the C front end

2024-10-31 Thread Joseph Myers
On Thu, 24 Oct 2024, alfie.richa...@arm.com wrote: > - if (DECL_INITIAL (newdecl)) > + if ((DECL_INITIAL (newdecl) || DECL_EXTERNAL (newdecl)) > + && (DECL_INITIAL (olddecl) || DECL_EXTERNAL (olddecl)) > + && targetm.target_option.function_versions (newdecl, olddecl)) > +

*Ping* [PATCH v2 1/1] C: Support Function multiversionsing in the C front end

2024-10-31 Thread Alfie Richards
Hi, Ping for this patch I'd really like to get this in for GCC 15 to align FMV with LLVM and avoid any divergence of use in code bases as much as possible as we push this more to users. Thanks, Alfie Richards > On 24 Oct 2024, at 13:54, alfie.richa...@arm.com wrote: > > > This patch adds su

[PATCH v2 1/1] C: Support Function multiversionsing in the C front end

2024-10-24 Thread alfie.richards
This patch adds support for `target_version` function multiversioning to the C frontend, specifically intended for enabling this for Aarch64 targets. The functionality and behavior matches the CPP frontend. This is likely to need to be changed later down the line for Aarch64 targets to match the