Re: [PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-04-11 Thread Richard Sandiford
Evgeny Karpov writes: > Wednesday, April 10, 2024 8:40 PM > Richard Sandiford wrote: > >> Thanks for the updates and sorry again for the slow review. >> I've replied to some of the patches in the series but otherwise it looks >> good to >> me. >> >> If you agree with the suggested changes then

[PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-04-11 Thread Evgeny Karpov
Wednesday, April 10, 2024 8:40 PM Richard Sandiford wrote: > Thanks for the updates and sorry again for the slow review. > I've replied to some of the patches in the series but otherwise it looks good > to > me. > > If you agree with the suggested changes then the series is OK for stage 1, >

Re: [PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-04-10 Thread Richard Sandiford
Evgeny Karpov writes: > Hello, > > v2 is ready for the review! > Based on the v1 review: > https://gcc.gnu.org/pipermail/gcc-patches/2024-February/thread.html#646203 > > Testing for the x86_64-w64-mingw32 target is in progress to avoid > regression due to refactoring. Thanks for the updates and

[PING][PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-03-21 Thread Evgeny Karpov
On Thursday, March 7, 2024 9:48 PM Evgeny Karpov wrote: > > Changes from v1 to v2: > > Adjust the target name to aarch64-*-mingw* to exclude the big-endian > > target from support. > > Exclude 64-bit ISA. > > Update commit descriptions to follow standard style. > > Rebase from 4th March 2024. >

Re: [PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-03-20 Thread NightStrike
/actions/runs/8349019387 > > Best regards, > > Radek Bartoň > > > From: Radek Barton > Sent: Monday, March 18, 2024 10:05 PM > To: Evgeny Karpov; gcc-patches@gcc.gnu.org > Cc: richard.sandif...@arm.com; Richard Earnshaw (lists); Andrew Pinski > (QU

Re: [PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-03-20 Thread Radek Barton
PATCH v2 00/13] Add aarch64-w64-mingw32 target Hello, everyone. Currently, we are able to provide results of regression testing for `x86_64-w64-mingw32` target with `--enable-languages=c,lto,c++,fortran` running in WSL only. The summarized results, both for the branch with patch set applied an

Re: [PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-03-19 Thread Martin Storsjö
On Mon, 18 Mar 2024, Fangrui Song wrote: LLVM has had an aarch64 mingw ABI support for a long time. Does this patch series introduce a different ABI? If yes, do you have a summary? This patchset in itself does not reach ABI compatibility with the preexisting aarch64 mingw ecosystem - but this

Re: [PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-03-18 Thread Andrew Pinski
On Mon, Mar 18, 2024 at 3:59 PM Fangrui Song wrote: > > On Mon, Mar 18, 2024 at 3:10 PM Evgeny Karpov > wrote: > > > > > > Monday, March 18, 2024 2:34 PM > > Christophe Lyon wrote: > > > > > I had a look at the v2 series, and besides a minor comment patch #8, ISTM > > > than > > > all the commen

Re: [PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-03-18 Thread Fangrui Song
On Mon, Mar 18, 2024 at 3:10 PM Evgeny Karpov wrote: > > > Monday, March 18, 2024 2:34 PM > Christophe Lyon wrote: > > > I had a look at the v2 series, and besides a minor comment patch #8, ISTM > > than > > all the comments your received about v1 have been addressed, indeed. > > > > > While unit

[PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-03-18 Thread Evgeny Karpov
Monday, March 18, 2024 2:34 PM Christophe Lyon wrote: > I had a look at the v2 series, and besides a minor comment patch #8, ISTM than > all the comments your received about v1 have been addressed, indeed. > > > While unit testing for the x86_64-w64-mingw32 target is still in > > progress, the

Re: [PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-03-18 Thread Radek Barton
Hello, everyone. Currently, we are able to provide results of regression testing for `x86_64-w64-mingw32` target with `--enable-languages=c,lto,c++,fortran` running in WSL only. The summarized results, both for the branch with patch set applied and its corresponding base branch, show: 517501

Re: [PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-03-18 Thread Christophe Lyon
On Thu, 7 Mar 2024 at 21:48, Evgeny Karpov wrote: > > Monday, March 4, 2024 > Evgeny Karpov wrote: > > > > > Changes from v1 to v2: > > Adjust the target name to aarch64-*-mingw* to exclude the big-endian target > > from support. > > Exclude 64-bit ISA. > > Rename enum calling_abi to aarch64_calli

[PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-03-07 Thread Evgeny Karpov
Monday, March 4, 2024 Evgeny Karpov wrote: > > Changes from v1 to v2: > Adjust the target name to aarch64-*-mingw* to exclude the big-endian target > from support. > Exclude 64-bit ISA. > Rename enum calling_abi to aarch64_calling_abi. > Move AArch64 MS ABI definitions FIXED_REGISTERS, > CALL_REAL

[PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-03-06 Thread Evgeny Karpov
Wednesday, March 6, 2024 LIU Hao wrote: > May I suggest you keep the mcf thread model for aarch-w64-mingw32? I > requested Martin Storsjö to test it on a physical Windows 11 on ARM machine > with Clang and all tests passed. I think it should work once the GCC support > is > complete. > > > -- >

Re: [PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-03-06 Thread LIU Hao
May I suggest you keep the mcf thread model for aarch-w64-mingw32? I requested Martin Storsjö to test it on a physical Windows 11 on ARM machine with Clang and all tests passed. I think it should work once the GCC support is complete. -- Best regards, LIU Hao OpenPGP_signature.asc Descriptio

[PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-03-04 Thread Evgeny Karpov
Zac Walker (13): Introduce aarch64-w64-mingw32 target aarch64: The aarch64-w64-mingw32 target implements the MS ABI aarch64: Mark x18 register as a fixed register for MS ABI aarch64: Add aarch64-w64-mingw32 COFF Reuse MinGW from i386 for AArch64 Rename section and encoding functions fro

[PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-03-04 Thread Evgeny Karpov
gcc/ChangeLog: * config.gcc: * config/aarch64/aarch64-opts.h (enum aarch64_calling_abi): * config/aarch64/aarch64-protos.h (mingw_pe_maybe_record_exported_symbol): (mingw_pe_section_type_flags): (mingw_pe_unique_section): (mingw_pe_encode_section_in

[PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-03-04 Thread Evgeny Karpov
Hello, v2 is ready for the review! Based on the v1 review: https://gcc.gnu.org/pipermail/gcc-patches/2024-February/thread.html#646203 Testing for the x86_64-w64-mingw32 target is in progress to avoid regression due to refactoring. Regards, Evgeny Changes from v1 to v2: Adjust the target name