Re: [PATCH v2] rs6000: Fix some issues in rs6000_can_inline_p [PR102059]

Hi Segher, on 2021/12/6 下午9:06, Segher Boessenkool wrote: > On Fri, Dec 03, 2021 at 11:46:53AM +0800, Kewen.Lin wrote: This patch is to fix the inconsistent behaviors for non-LTO mode and LTO mode. As Martin pointed out, currently the function rs6000_can_inline_p simply makes it in

Re: [PATCH v2] rs6000: Fix some issues in rs6000_can_inline_p [PR102059]

On 12/6/21 7:06 AM, Segher Boessenkool wrote: > On Fri, Dec 03, 2021 at 11:46:53AM +0800, Kewen.Lin wrot >> Without this fix, bar inlines foo but get the error as below: >> >> In function ‘foo’, >> inlined from ‘bar’ at test.c:8:8: >> test.c:3:9: error: ‘__builtin_ttest’ requires the ‘-mhtm’ op

Re: [PATCH v2] rs6000: Fix some issues in rs6000_can_inline_p [PR102059]

On 12/6/21 3:35 AM, Martin Liška wrote: > On 12/4/21 00:23, Peter Bergner wrote: >> I thought Martin and richi mentioned that target attribute options >> are treated as if they are appended to the end of the command line >> options, so they can potentially override earlier options, but they >> don'

Re: [PATCH v2] rs6000: Fix some issues in rs6000_can_inline_p [PR102059]

On Fri, Dec 03, 2021 at 11:46:53AM +0800, Kewen.Lin wrote: > >> This patch is to fix the inconsistent behaviors for non-LTO mode > >> and LTO mode. As Martin pointed out, currently the function > >> rs6000_can_inline_p simply makes it inlinable if callee_tree is > >> NULL, but it's wrong, we shoul

Re: [PATCH v2] rs6000: Fix some issues in rs6000_can_inline_p [PR102059]

On 12/4/21 00:23, Peter Bergner wrote: On 12/2/21 9:46 PM, Kewen.Lin via Gcc-patches wrote: on 2021/11/30 上午12:57, Segher Boessenkool wrote: On Wed, Sep 01, 2021 at 02:55:51PM +0800, Kewen.Lin wrote: This patch is to fix the inconsistent behaviors for non-LTO mode and LTO mode. As Martin poin

Re: [PATCH v2] rs6000: Fix some issues in rs6000_can_inline_p [PR102059]

On 12/2/21 9:46 PM, Kewen.Lin via Gcc-patches wrote: > on 2021/11/30 上午12:57, Segher Boessenkool wrote: >> On Wed, Sep 01, 2021 at 02:55:51PM +0800, Kewen.Lin wrote: >>> This patch is to fix the inconsistent behaviors for non-LTO mode >>> and LTO mode. As Martin pointed out, currently the function

[PATCH v2] rs6000: Fix some issues in rs6000_can_inline_p [PR102059]

Hi Segher, Thanks for the review! on 2021/11/30 上午12:57, Segher Boessenkool wrote: > Hi! > > On Wed, Sep 01, 2021 at 02:55:51PM +0800, Kewen.Lin wrote: >> This patch is to fix the inconsistent behaviors for non-LTO mode >> and LTO mode. As Martin pointed out, currently the function >> rs6000_ca