> > the specified width may differ from the width of the type
> > used.
> >
> > Built/tested on x86_64-linux-gnu.
>
>
> Sorry for the delay and thanks for your patience! Some initial review
> comments below.
>
> > * 1nfocalypse
>
> > Subj
On Fri, 11 Jul 2025 at 18:12, Jonathan Wakely wrote:
> > > +static constexpr std::array multipliers =
> > > + philox_engine::__popMultArray();
> > > +static constexpr std::array round_consts =
> > > + philox_engine::__popConstArray();
>
> Since you're creating static data m
e bit manipulation rather than numeric_limits, since
> > the specified width may differ from the width of the type
> > used.
> >
> > Built/tested on x86_64-linux-gnu.
>
> Sorry for the delay and thanks for your patience! Some initial review
> comments below.
>
64-linux-gnu.
Sorry for the delay and thanks for your patience! Some initial review
comments below.
>
> * 1nfocalypse
> >
> >
> Subject: [PATCH] [PATCH v2] libstdc++: implement Philox Engine [PR119794]
>
> The template unpacking functions, while private, are placed prior
&
Hi,
On Thu, 22 May 2025, 1nfocalypse wrote:
> Implements Philox Engine (P2075R6) and associated tests.
>
> v2 corrects a multiline comment left in error in serialize.cc, and
> additionally corrects a bug hidden by said comment, where the stream was
> given the output of 'y()' instead of 'y', c
0000
Subject: [PATCH] [PATCH v2] libstdc++: implement Philox Engine [PR119794]
The template unpacking functions, while private, are placed prior
to the public access specifier due to issues where the template
pack could not be unpacked and used to populate the public member
arrays without being dec