Re: [PATCH v2] libgo: Add support for sh

2018-01-10 Thread John Paul Adrian Glaubitz
On 01/10/2018 04:22 PM, Ian Lance Taylor wrote: Ok, so basically we should end up having only two GOARCHes for SH, being "sh" and "shbe", correct? Yes, I would like to start there. If, yes, I can rebase my patch, make the requested changes and resubmit it to Gerrit. Thanks! Done: https://g

Re: [PATCH v2] libgo: Add support for sh

2018-01-10 Thread Ian Lance Taylor
On Wed, Jan 10, 2018 at 7:05 AM, John Paul Adrian Glaubitz wrote: > On 01/10/2018 03:51 PM, Ian Lance Taylor wrote: >> >> I suppose I shouldn't have said calling convention, as that cuts too >> finely. There are similar issues with MIPS and even x86 has softfloat >> variants. Those options are s

Re: [PATCH v2] libgo: Add support for sh

2018-01-10 Thread John Paul Adrian Glaubitz
On 01/10/2018 03:51 PM, Ian Lance Taylor wrote: I suppose I shouldn't have said calling convention, as that cuts too finely. There are similar issues with MIPS and even x86 has softfloat variants. Those options are selectable via command line options in GCC, and in the gc toolchain they are sel

Re: [PATCH v2] libgo: Add support for sh

2018-01-10 Thread Ian Lance Taylor
On Wed, Jan 10, 2018 at 6:30 AM, Oleg Endo wrote: > On Wed, 2018-01-10 at 06:25 -0800, Ian Lance Taylor wrote: >> >> Thanks. I finally took a look at this. I don't know much about SH, >> but I don't think we want to add each SH variant as a separate GOARCH >> value. As you can see from the list

Re: [PATCH v2] libgo: Add support for sh

2018-01-10 Thread John Paul Adrian Glaubitz
On 01/10/2018 03:40 PM, Ian Lance Taylor wrote: The main purpose of a GOARCH value is to specify build targets, which are the +build lines seen in files like libgo/go/internal/syscall/unix/getrandom_linux_mipsx.go. They also appear in file names. It seems to me unlikely that it will ever be nec

Re: [PATCH v2] libgo: Add support for sh

2018-01-10 Thread Ian Lance Taylor
On Wed, Jan 10, 2018 at 6:30 AM, John Paul Adrian Glaubitz wrote: > On 01/10/2018 03:25 PM, Ian Lance Taylor wrote: >> >> Thanks. I finally took a look at this. I don't know much about SH, >> but I don't think we want to add each SH variant as a separate GOARCH >> value. As you can see from the

Re: [PATCH v2] libgo: Add support for sh

2018-01-10 Thread Oleg Endo
On Wed, 2018-01-10 at 06:25 -0800, Ian Lance Taylor wrote: >  > Thanks.  I finally took a look at this.  I don't know much about SH, > but I don't think we want to add each SH variant as a separate GOARCH > value.  As you can see from the list you modified in > ibgo/go/go/build/syslist.go, the diff

Re: [PATCH v2] libgo: Add support for sh

2018-01-10 Thread John Paul Adrian Glaubitz
On 01/10/2018 03:25 PM, Ian Lance Taylor wrote: Thanks. I finally took a look at this. I don't know much about SH, but I don't think we want to add each SH variant as a separate GOARCH value. As you can see from the list you modified in ibgo/go/go/build/syslist.go, the difference between GOARC

Re: [PATCH v2] libgo: Add support for sh

2018-01-10 Thread Ian Lance Taylor
On Sun, Dec 17, 2017 at 4:38 AM, John Paul Adrian Glaubitz wrote: > > This is the second version of my patch to add support for SuperH > in libgo. The changes over my first patch in [1] are: > > * account for little- and big-endian targets > * account for sh3- and sh4-specific parameters > > I h

[PATCH v2] libgo: Add support for sh

2017-12-17 Thread John Paul Adrian Glaubitz
Hello! This is the second version of my patch to add support for SuperH in libgo. The changes over my first patch in [1] are: * account for little- and big-endian targets * account for sh3- and sh4-specific parameters I have not added support for SH-1 and SH-2 targets for now as most Linux dis