Re: [PATCH v2] libgcc: Use braces instead of macro's empty body to avoid xgcc warnings.

2015-04-15 Thread Jeff Law
This patch was originally from Chen Gang S. However, his address at sunrus.com.cn bounces. So presumably he didn't get the approved message. I'm checking in the patch for him (with the fixed ChangeLog). I've verified by hand that the warning goes away with a cross toolchain and that it do

Re: [PATCH v2] libgcc: Use braces instead of macro's empty body to avoid xgcc warnings.

2015-04-13 Thread Jeff Law
On 01/30/2015 11:04 PM, Chen Gang S wrote: The related warning (cross compile tile with --disable-threads): ../../../../gcc-tile-new/libgcc/libgcov-interface.c: In function '__gcov_fork': ../../../../gcc-tile-new/libgcc/libgcov-interface.c:182:53: warning: suggest braces around empty bod

Re: [PATCH v2] libgcc: Use braces instead of macro's empty body to avoid xgcc warnings.

2015-01-31 Thread Chen Gang S
On 1/31/15 19:49, Marek Polacek wrote: > On Sat, Jan 31, 2015 at 05:13:53PM +0530, Prathamesh Kulkarni wrote: >> On 31 January 2015 at 15:30, Chen Gang S wrote: >>> On 1/31/15 16:53, Andreas Schwab wrote: Chen Gang S writes: > * gthr-single.h (__GTHREAD_MUTEX_INIT_FUNCTION): Us

Re: [PATCH v2] libgcc: Use braces instead of macro's empty body to avoid xgcc warnings.

2015-01-31 Thread Marek Polacek
On Sat, Jan 31, 2015 at 05:13:53PM +0530, Prathamesh Kulkarni wrote: > On 31 January 2015 at 15:30, Chen Gang S wrote: > > On 1/31/15 16:53, Andreas Schwab wrote: > >> Chen Gang S writes: > >> > >>> * gthr-single.h (__GTHREAD_MUTEX_INIT_FUNCTION): Use braces > >>> instead of macro's emp

Re: [PATCH v2] libgcc: Use braces instead of macro's empty body to avoid xgcc warnings.

2015-01-31 Thread Prathamesh Kulkarni
On 31 January 2015 at 15:30, Chen Gang S wrote: > On 1/31/15 16:53, Andreas Schwab wrote: >> Chen Gang S writes: >> >>> * gthr-single.h (__GTHREAD_MUTEX_INIT_FUNCTION): Use braces >>> instead of macro's empty body to avoid xgcc warnings. The ChangeLog entry should be fixed to reflect it

Re: [PATCH v2] libgcc: Use braces instead of macro's empty body to avoid xgcc warnings.

2015-01-31 Thread Chen Gang S
On 1/31/15 16:53, Andreas Schwab wrote: > Chen Gang S writes: > >> * gthr-single.h (__GTHREAD_MUTEX_INIT_FUNCTION): Use braces >> instead of macro's empty body to avoid xgcc warnings. > > It's actually an empty loop now. > Excuse me, I am not quite clear gcc version merging working f

Re: [PATCH v2] libgcc: Use braces instead of macro's empty body to avoid xgcc warnings.

2015-01-31 Thread Andreas Schwab
Chen Gang S writes: > * gthr-single.h (__GTHREAD_MUTEX_INIT_FUNCTION): Use braces > instead of macro's empty body to avoid xgcc warnings. It's actually an empty loop now. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 21

[PATCH v2] libgcc: Use braces instead of macro's empty body to avoid xgcc warnings.

2015-01-30 Thread Chen Gang S
The related warning (cross compile tile with --disable-threads): ../../../../gcc-tile-new/libgcc/libgcov-interface.c: In function '__gcov_fork': ../../../../gcc-tile-new/libgcc/libgcov-interface.c:182:53: warning: suggest braces around empty body in an 'if' statement [-Wempty-body] __