Re: [PATCH v2] coroutines: Ensure there's a top level bind when rewriting [PR106188]

2022-09-07 Thread Arsen Arsenović via Gcc-patches
Hi, On Wednesday, 7 September 2022 17:13:03 CEST Jason Merrill wrote: > Applied with some minor tweaks, described below. > > Thanks! Got it, and noted the changes and rationale you provided Thank you! -- Arsen Arsenović signature.asc Description: This is a digitally signed message part.

Re: [PATCH v2] coroutines: Ensure there's a top level bind when rewriting [PR106188]

2022-09-07 Thread Jason Merrill via Gcc-patches
On 9/4/22 15:04, Arsen Arsenović wrote: In the edge case of a coroutine not containing any locals, the ifcd/swch temporaries would get added to the coroutine frame, corrupting its layout. To prevent this, we can make sure there is always a BIND_EXPR at the top of the function body, and thus, alwa

Re: [PATCH v2] coroutines: Ensure there's a top level bind when rewriting [PR106188]

2022-09-05 Thread Arsen Arsenović via Gcc-patches
Hi, On Monday, 5 September 2022 00:09:51 CEST Iain Sandoe wrote: > LGTM, but I cannot actually approve it - please wait for an ack from > Jason or Nathan (or one of the other global maintainers). Will do. Thank you for your assistance. Have a good day, -- Arsen Arsenović signature.asc Descript

Re: [PATCH v2] coroutines: Ensure there's a top level bind when rewriting [PR106188]

2022-09-04 Thread Iain Sandoe
Hi Arsen, > On 4 Sep 2022, at 20:04, Arsen Arsenović wrote: > > In the edge case of a coroutine not containing any locals, the ifcd/swch > temporaries would get added to the coroutine frame, corrupting its > layout. To prevent this, we can make sure there is always a BIND_EXPR at > the top of th

[PATCH v2] coroutines: Ensure there's a top level bind when rewriting [PR106188]

2022-09-04 Thread Arsen Arsenović via Gcc-patches
In the edge case of a coroutine not containing any locals, the ifcd/swch temporaries would get added to the coroutine frame, corrupting its layout. To prevent this, we can make sure there is always a BIND_EXPR at the top of the function body, and thus, always a place for our new temporaries to go w