Re: [PATCH v2] configure: define TARGET_LIBC_GNUSTACK on musl

2021-12-02 Thread Jeff Law via Gcc-patches
On 12/2/2021 1:59 PM, Ilya Lipnitskiy wrote: On Thu, Dec 2, 2021 at 12:48 PM Jeff Law wrote: On 11/15/2021 10:13 PM, Ilya Lipnitskiy wrote: musl only uses PT_GNU_STACK to set default thread stack size and has no executable stack support[0], so there is no reason not to emit the .note.GNU-

Re: [PATCH v2] configure: define TARGET_LIBC_GNUSTACK on musl

2021-12-02 Thread Ilya Lipnitskiy via Gcc-patches
On Thu, Dec 2, 2021 at 12:48 PM Jeff Law wrote: > > > > On 11/15/2021 10:13 PM, Ilya Lipnitskiy wrote: > > musl only uses PT_GNU_STACK to set default thread stack size and has no > > executable stack support[0], so there is no reason not to emit the > > .note.GNU-stack section on musl builds. > >

Re: [PATCH v2] configure: define TARGET_LIBC_GNUSTACK on musl

2021-12-02 Thread Jeff Law via Gcc-patches
On 11/15/2021 10:13 PM, Ilya Lipnitskiy wrote: musl only uses PT_GNU_STACK to set default thread stack size and has no executable stack support[0], so there is no reason not to emit the .note.GNU-stack section on musl builds. [0]: https://lore.kernel.org/all/20190423192534.gn23...@brightrain

Re: [musl] Re: [PATCH v2] configure: define TARGET_LIBC_GNUSTACK on musl

2021-11-16 Thread Ilya Lipnitskiy via Gcc-patches
On Tue, Nov 16, 2021 at 8:41 AM Rich Felker wrote: > > On Tue, Nov 16, 2021 at 03:40:00PM +0100, Dragan Mladjenovic wrote: > > Hi, > > > > Looks fine to me. If possible, maybe it should even be back-ported > > to stable branches. The change cherry-picks fine onto 10.x and 11.x branches. Should I s

Re: [musl] Re: [PATCH v2] configure: define TARGET_LIBC_GNUSTACK on musl

2021-11-16 Thread Rich Felker
On Tue, Nov 16, 2021 at 03:40:00PM +0100, Dragan Mladjenovic wrote: > Hi, > > Looks fine to me. If possible, maybe it should even be back-ported > to stable branches. > > Not sure if MIPS assembly sources (if any) in musl would need > explicit ..note.GNU-stack > > to complement this? What are t

Re: [PATCH v2] configure: define TARGET_LIBC_GNUSTACK on musl

2021-11-16 Thread Dragan Mladjenovic
Hi, Looks fine to me. If possible, maybe it should even be back-ported to stable branches. Not sure if MIPS assembly sources (if any) in musl would need explicit .note.GNU-stack to complement this? Best regards, Dragan On 16-Nov-21 06:13, Ilya Lipnitskiy wrote: musl only uses PT_GNU_STA

[PATCH v2] configure: define TARGET_LIBC_GNUSTACK on musl

2021-11-15 Thread Ilya Lipnitskiy via Gcc-patches
musl only uses PT_GNU_STACK to set default thread stack size and has no executable stack support[0], so there is no reason not to emit the .note.GNU-stack section on musl builds. [0]: https://lore.kernel.org/all/20190423192534.gn23...@brightrain.aerifal.cx/T/#u gcc/ChangeLog: * configur