Re: [PATCH v2] c++: parser - Support for target address spaces in C++

2022-10-14 Thread Jason Merrill via Gcc-patches
On 10/13/22 17:57, Paul Iannetta wrote: On Thu, Oct 13, 2022 at 03:41:16PM -0400, Jason Merrill wrote: On 10/13/22 12:02, Paul Iannetta wrote: On Thu, Oct 13, 2022 at 11:47:42AM -0400, Jason Merrill wrote: On 10/13/22 11:23, Paul Iannetta wrote: On Thu, Oct 13, 2022 at 11:02:24AM -0400, Jason

Re: [PATCH v2] c++: parser - Support for target address spaces in C++

2022-10-13 Thread Paul Iannetta via Gcc-patches
On Thu, Oct 13, 2022 at 03:41:16PM -0400, Jason Merrill wrote: > On 10/13/22 12:02, Paul Iannetta wrote: > > On Thu, Oct 13, 2022 at 11:47:42AM -0400, Jason Merrill wrote: > > > On 10/13/22 11:23, Paul Iannetta wrote: > > > > On Thu, Oct 13, 2022 at 11:02:24AM -0400, Jason Merrill wrote: > > > > >

Re: [PATCH v2] c++: parser - Support for target address spaces in C++

2022-10-13 Thread Jason Merrill via Gcc-patches
On 10/13/22 12:02, Paul Iannetta wrote: On Thu, Oct 13, 2022 at 11:47:42AM -0400, Jason Merrill wrote: On 10/13/22 11:23, Paul Iannetta wrote: On Thu, Oct 13, 2022 at 11:02:24AM -0400, Jason Merrill wrote: On 10/12/22 20:52, Paul Iannetta wrote: On Tue, Oct 11, 2022 at 09:49:43PM -0400, Jason

Re: [PATCH v2] c++: parser - Support for target address spaces in C++

2022-10-13 Thread Paul Iannetta via Gcc-patches
On Thu, Oct 13, 2022 at 11:47:42AM -0400, Jason Merrill wrote: > On 10/13/22 11:23, Paul Iannetta wrote: > > On Thu, Oct 13, 2022 at 11:02:24AM -0400, Jason Merrill wrote: > > > On 10/12/22 20:52, Paul Iannetta wrote: > > > > On Tue, Oct 11, 2022 at 09:49:43PM -0400, Jason Merrill wrote: > > > > >

Re: [PATCH v2] c++: parser - Support for target address spaces in C++

2022-10-13 Thread Jason Merrill via Gcc-patches
On 10/13/22 11:23, Paul Iannetta wrote: On Thu, Oct 13, 2022 at 11:02:24AM -0400, Jason Merrill wrote: On 10/12/22 20:52, Paul Iannetta wrote: On Tue, Oct 11, 2022 at 09:49:43PM -0400, Jason Merrill wrote: It surprises that this is the only place we complain about an object with an address-sp

Re: [PATCH v2] c++: parser - Support for target address spaces in C++

2022-10-13 Thread Paul Iannetta via Gcc-patches
On Thu, Oct 13, 2022 at 11:02:24AM -0400, Jason Merrill wrote: > On 10/12/22 20:52, Paul Iannetta wrote: > > On Tue, Oct 11, 2022 at 09:49:43PM -0400, Jason Merrill wrote: > > > > > > It surprises that this is the only place we complain about an object with > > > an > > > address-space qualifier.

Re: [PATCH v2] c++: parser - Support for target address spaces in C++

2022-10-13 Thread Paul Iannetta via Gcc-patches
On Thu, Oct 13, 2022 at 07:46:46AM +0200, Jakub Jelinek wrote: > On Thu, Oct 13, 2022 at 02:52:59AM +0200, Paul Iannetta via Gcc-patches wrote: > > + if (type != error_mark_node > > + && !ADDR_SPACE_GENERIC_P (TYPE_ADDR_SPACE (type)) > > + && current_function_d

Re: [PATCH v2] c++: parser - Support for target address spaces in C++

2022-10-13 Thread Jason Merrill via Gcc-patches
On 10/12/22 20:52, Paul Iannetta wrote: On Tue, Oct 11, 2022 at 09:49:43PM -0400, Jason Merrill wrote: It surprises that this is the only place we complain about an object with an address-space qualifier. Shouldn't we also complain about e.g. automatic variables/parameters or non-static data m

Re: [PATCH v2] c++: parser - Support for target address spaces in C++

2022-10-12 Thread Jakub Jelinek via Gcc-patches
On Thu, Oct 13, 2022 at 02:52:59AM +0200, Paul Iannetta via Gcc-patches wrote: > + if (type != error_mark_node > + && !ADDR_SPACE_GENERIC_P (TYPE_ADDR_SPACE (type)) > + && current_function_decl) > + { > + error > +

Re: [PATCH v2] c++: parser - Support for target address spaces in C++

2022-10-12 Thread Paul Iannetta via Gcc-patches
On Tue, Oct 11, 2022 at 09:49:43PM -0400, Jason Merrill wrote: > > It surprises that this is the only place we complain about an object with an > address-space qualifier. Shouldn't we also complain about e.g. automatic > variables/parameters or non-static data members with address-space qualified

Re: [PATCH v2] c++: parser - Support for target address spaces in C++

2022-10-11 Thread Jason Merrill via Gcc-patches
On 10/11/22 18:03, Paul Iannetta wrote: Thank you very much for the comments. On Mon, Oct 10, 2022 at 03:20:13PM -0400, Jason Merrill wrote: On 10/9/22 12:12, Paul Iannetta wrote: That's a nice feature! LLVM is using AS to mangle the address-name qualified types but that would have required an

Re: [PATCH v2] c++: parser - Support for target address spaces in C++

2022-10-11 Thread Paul Iannetta via Gcc-patches
Thank you very much for the comments. On Mon, Oct 10, 2022 at 03:20:13PM -0400, Jason Merrill wrote: > On 10/9/22 12:12, Paul Iannetta wrote: > > That's a nice feature! LLVM is using AS to mangle the > > address-name qualified types but that would have required an update of > > libiberty's demangl