Re: [PATCH v2] c++: Prevent warnings for value-dependent exprs [PR96742]

2020-11-03 Thread Marek Polacek via Gcc-patches
On Sat, Oct 31, 2020 at 10:09:32AM +, Iain Sandoe wrote: > Hi Marek, > > Marek Polacek via Gcc-patches wrote: > > > On Wed, Oct 28, 2020 at 02:46:36PM -0400, Jason Merrill wrote: > >> On 10/28/20 2:00 PM, Marek Polacek wrote: > >>> On Tue, Oct 27, 2020 at 01:36:30PM -0400, Jason Merrill wrot

Re: [PATCH v2] c++: Prevent warnings for value-dependent exprs [PR96742]

2020-10-31 Thread Iain Sandoe via Gcc-patches
Hi Marek, Marek Polacek via Gcc-patches wrote: > On Wed, Oct 28, 2020 at 02:46:36PM -0400, Jason Merrill wrote: >> On 10/28/20 2:00 PM, Marek Polacek wrote: >>> On Tue, Oct 27, 2020 at 01:36:30PM -0400, Jason Merrill wrote: On 10/24/20 6:52 PM, Marek Polacek wrote: > Here, in r11-155, I

Re: [PATCH v2] c++: Prevent warnings for value-dependent exprs [PR96742]

2020-10-29 Thread Jason Merrill via Gcc-patches
On 10/28/20 10:45 PM, Marek Polacek wrote: On Wed, Oct 28, 2020 at 05:48:08PM -0400, Jason Merrill wrote: On 10/28/20 5:29 PM, Marek Polacek wrote: On Wed, Oct 28, 2020 at 02:46:36PM -0400, Jason Merrill wrote: On 10/28/20 2:00 PM, Marek Polacek wrote: On Tue, Oct 27, 2020 at 01:36:30PM -0400

Re: [PATCH v2] c++: Prevent warnings for value-dependent exprs [PR96742]

2020-10-28 Thread Marek Polacek via Gcc-patches
On Wed, Oct 28, 2020 at 05:48:08PM -0400, Jason Merrill wrote: > On 10/28/20 5:29 PM, Marek Polacek wrote: > > On Wed, Oct 28, 2020 at 02:46:36PM -0400, Jason Merrill wrote: > > > On 10/28/20 2:00 PM, Marek Polacek wrote: > > > > On Tue, Oct 27, 2020 at 01:36:30PM -0400, Jason Merrill wrote: > > >

Re: [PATCH v2] c++: Prevent warnings for value-dependent exprs [PR96742]

2020-10-28 Thread Jason Merrill via Gcc-patches
On 10/28/20 5:29 PM, Marek Polacek wrote: On Wed, Oct 28, 2020 at 02:46:36PM -0400, Jason Merrill wrote: On 10/28/20 2:00 PM, Marek Polacek wrote: On Tue, Oct 27, 2020 at 01:36:30PM -0400, Jason Merrill wrote: On 10/24/20 6:52 PM, Marek Polacek wrote: Here, in r11-155, I changed the call to u

Re: [PATCH v2] c++: Prevent warnings for value-dependent exprs [PR96742]

2020-10-28 Thread Marek Polacek via Gcc-patches
On Wed, Oct 28, 2020 at 02:46:36PM -0400, Jason Merrill wrote: > On 10/28/20 2:00 PM, Marek Polacek wrote: > > On Tue, Oct 27, 2020 at 01:36:30PM -0400, Jason Merrill wrote: > > > On 10/24/20 6:52 PM, Marek Polacek wrote: > > > > Here, in r11-155, I changed the call to uses_template_parms to > > >

Re: [PATCH v2] c++: Prevent warnings for value-dependent exprs [PR96742]

2020-10-28 Thread Jason Merrill via Gcc-patches
On 10/28/20 2:00 PM, Marek Polacek wrote: On Tue, Oct 27, 2020 at 01:36:30PM -0400, Jason Merrill wrote: On 10/24/20 6:52 PM, Marek Polacek wrote: Here, in r11-155, I changed the call to uses_template_parms to type_dependent_expression_p_push to avoid a crash in C++98 in value_dependent_express

Re: [PATCH v2] c++: Prevent warnings for value-dependent exprs [PR96742]

2020-10-28 Thread Marek Polacek via Gcc-patches
On Tue, Oct 27, 2020 at 01:36:30PM -0400, Jason Merrill wrote: > On 10/24/20 6:52 PM, Marek Polacek wrote: > > Here, in r11-155, I changed the call to uses_template_parms to > > type_dependent_expression_p_push to avoid a crash in C++98 in > > value_dependent_expression_p on a non-constant expressi