Re: [PATCH v2] c++, coroutines: Rework the ramp codegen.

2024-09-20 Thread Iain Sandoe
> On 17 Sep 2024, at 22:05, Jason Merrill wrote: > > On 8/29/24 9:10 PM, Iain Sandoe wrote: >> + /* deref the frame pointer, to use in member access code. */ >> + tree deref_fp >> += cp_build_indirect_ref (loc, coro_fp, RO_UNARY_STAR, >> + tf_warning_or_error);

Re: [PATCH v2] c++, coroutines: Rework the ramp codegen.

2024-09-17 Thread Jason Merrill
On 8/29/24 9:10 PM, Iain Sandoe wrote: Hi Jason, - char *buf = xasprintf ("_Coro_unnamed_parm_%d", no_name_parm++); + char *buf = xasprintf ("anon%d", parm_num); Why the reduction in verbosity here? I was getting ahead of myself; not intended in this patch. Fixed. + p =

[ping] Re: [PATCH v2] c++, coroutines: Rework the ramp codegen.

2024-09-17 Thread Iain Sandoe
Hi Jason, gentle ping for this one. > On 29 Aug 2024, at 20:10, Iain Sandoe wrote: > > Hi Jason, > >>> - char *buf = xasprintf ("_Coro_unnamed_parm_%d", no_name_parm++); >>> + char *buf = xasprintf ("anon%d", parm_num); > >> Why the reduction in verbosity here? > I was getting ahead o

[PATCH v2] c++, coroutines: Rework the ramp codegen.

2024-08-29 Thread Iain Sandoe
Hi Jason, >>- char *buf = xasprintf ("_Coro_unnamed_parm_%d", no_name_parm++); >>+ char *buf = xasprintf ("anon%d", parm_num); >Why the reduction in verbosity here? I was getting ahead of myself; not intended in this patch. Fixed. >>+ p = pushdecl_outermost_localscope (p); >>+ add