Re: [PATCH v2] aarch64: Ignore target pragmas while defining intrinsics

2025-02-21 Thread Andrew Carlotti
On Fri, Feb 21, 2025 at 11:28:14AM +, Richard Sandiford wrote: > Andrew Carlotti writes: > > On Wed, Feb 19, 2025 at 12:17:55PM +, Richard Sandiford wrote: > >> Andrew Carlotti writes: > >> > /* Print a list of CANDIDATES for an argument, and try to suggest a > >> > specific > >> >

Re: [PATCH v2] aarch64: Ignore target pragmas while defining intrinsics

2025-02-21 Thread Richard Sandiford
Andrew Carlotti writes: > On Wed, Feb 19, 2025 at 12:17:55PM +, Richard Sandiford wrote: >> Andrew Carlotti writes: >> > /* Print a list of CANDIDATES for an argument, and try to suggest a >> > specific >> > close match. */ >> > diff --git a/gcc/config/aarch64/aarch64-builtins.cc >> >

Re: [PATCH v2] aarch64: Ignore target pragmas while defining intrinsics

2025-02-20 Thread Andrew Carlotti
On Wed, Feb 19, 2025 at 12:17:55PM +, Richard Sandiford wrote: > Andrew Carlotti writes: > > [...] > > @@ -204,6 +207,18 @@ static constexpr aarch64_processor_info all_cores[] = > >{NULL, aarch64_no_cpu, aarch64_no_arch, 0} > > }; > > > > +/* Return the set of feature flags that are req

Re: [PATCH v2] aarch64: Ignore target pragmas while defining intrinsics

2025-02-19 Thread Richard Sandiford
Andrew Carlotti writes: > [...] > @@ -204,6 +207,18 @@ static constexpr aarch64_processor_info all_cores[] = >{NULL, aarch64_no_cpu, aarch64_no_arch, 0} > }; > > +/* Return the set of feature flags that are required to be enabled when the > + features in FLAGS are enabled. */ > + > +aarc

[PATCH v2] aarch64: Ignore target pragmas while defining intrinsics

2025-02-18 Thread Andrew Carlotti
Compared to v1, I've added a new function aarch64_get_required_features to avoid having to pass a long list of explicit features. I also changed aarch64_target_switcher to only disable TARGET_GENERAL_REGS_ONLY if the requested flags include FP, to address Richard's comment. Bootstrapped and regre