Re: [PATCH v2] Support ASan ODR indicators at compiler side.

2016-11-21 Thread Maxim Ostapenko
On 21/11/16 15:17, Jakub Jelinek wrote: On Mon, Nov 21, 2016 at 12:09:30PM +, Yuri Gribov wrote: On Mon, Nov 21, 2016 at 11:50 AM, Jakub Jelinek wrote: On Mon, Nov 21, 2016 at 11:43:56AM +, Yuri Gribov wrote: This is just weird. DECL_NAME in theory could be NULL, or can be a symbol m

Re: [PATCH v2] Support ASan ODR indicators at compiler side.

2016-11-21 Thread Maxim Ostapenko
On 21/11/16 15:17, Jakub Jelinek wrote: On Mon, Nov 21, 2016 at 12:09:30PM +, Yuri Gribov wrote: On Mon, Nov 21, 2016 at 11:50 AM, Jakub Jelinek wrote: On Mon, Nov 21, 2016 at 11:43:56AM +, Yuri Gribov wrote: This is just weird. DECL_NAME in theory could be NULL, or can be a symbol m

Re: [PATCH v2] Support ASan ODR indicators at compiler side.

2016-11-21 Thread Jakub Jelinek
On Mon, Nov 21, 2016 at 12:09:30PM +, Yuri Gribov wrote: > On Mon, Nov 21, 2016 at 11:50 AM, Jakub Jelinek wrote: > > On Mon, Nov 21, 2016 at 11:43:56AM +, Yuri Gribov wrote: > >> > This is just weird. DECL_NAME in theory could be NULL, or can be a > >> > symbol > >> > much longer than 1

Re: [PATCH v2] Support ASan ODR indicators at compiler side.

2016-11-21 Thread Yuri Gribov
On Mon, Nov 21, 2016 at 11:50 AM, Jakub Jelinek wrote: > On Mon, Nov 21, 2016 at 11:43:56AM +, Yuri Gribov wrote: >> > This is just weird. DECL_NAME in theory could be NULL, or can be a symbol >> > much longer than 100 bytes, at which point you have strlen (tmp_name) == 99 >> > and ASM_GENERA

Re: [PATCH v2] Support ASan ODR indicators at compiler side.

2016-11-21 Thread Jakub Jelinek
On Mon, Nov 21, 2016 at 11:43:56AM +, Yuri Gribov wrote: > > This is just weird. DECL_NAME in theory could be NULL, or can be a symbol > > much longer than 100 bytes, at which point you have strlen (tmp_name) == 99 > > and ASM_GENERATE_INTERNAL_LABEL will just misbehave. > > I fail to see why

Re: [PATCH v2] Support ASan ODR indicators at compiler side.

2016-11-21 Thread Yuri Gribov
On Mon, Nov 21, 2016 at 11:38 AM, Jakub Jelinek wrote: > On Mon, Nov 14, 2016 at 11:44:26AM +0300, Maxim Ostapenko wrote: >> this is the second attempt to support ASan odr indicators in GCC. I've fixed >> issues with several flags (e.g.TREE_ADDRESSABLE) and introduced new "asan >> odr indicator" a

Re: [PATCH v2] Support ASan ODR indicators at compiler side.

2016-11-21 Thread Jakub Jelinek
On Mon, Nov 14, 2016 at 11:44:26AM +0300, Maxim Ostapenko wrote: > this is the second attempt to support ASan odr indicators in GCC. I've fixed > issues with several flags (e.g.TREE_ADDRESSABLE) and introduced new "asan > odr indicator" attribute to distinguish indicators from other symbols. > Look

[PATCH v2] Support ASan ODR indicators at compiler side.

2016-11-14 Thread Maxim Ostapenko
Hi, this is the second attempt to support ASan odr indicators in GCC. I've fixed issues with several flags (e.g.TREE_ADDRESSABLE) and introduced new "asan odr indicator" attribute to distinguish indicators from other symbols. Looks better now? Tested and ASan bootstrapped on x86_64-unknown-l