Re: [PATCH v2] RISC-V: Split off shift patterns for autovectorization.

2023-05-11 Thread Palmer Dabbelt
On Thu, 11 May 2023 07:21:30 PDT (-0700), jeffreya...@gmail.com wrote: On 5/11/23 04:33, Robin Dapp wrote: "csr_operand" does seem wrong, though, as that just accepts constants. Maybe "arith_operand" is the way to go? I haven't looked at the V immediates though. I was pondering changing the s

Re: [PATCH v2] RISC-V: Split off shift patterns for autovectorization.

2023-05-11 Thread Jeff Law via Gcc-patches
On 5/11/23 04:33, Robin Dapp wrote: "csr_operand" does seem wrong, though, as that just accepts constants. Maybe "arith_operand" is the way to go? I haven't looked at the V immediates though. I was pondering changing the shift-count operand to QImode everywhere but that indeed does not help

Re: [PATCH v2] RISC-V: Split off shift patterns for autovectorization.

2023-05-11 Thread Kito Cheng via Gcc-patches
llison; jeffreyalaw; rdapp.gcc > Subject: [PATCH v2] RISC-V: Split off shift patterns for autovectorization. > > "csr_operand" does seem wrong, though, as that just accepts constants. > > Maybe "arith_operand" is the way to go? I haven't looked at the > &g

Re: [PATCH v2] RISC-V: Split off shift patterns for autovectorization.

2023-05-11 Thread juzhe.zh...@rivai.ai
LGTM. Plz commit it now. Then I can rebase vec_init patch. juzhe.zh...@rivai.ai From: Robin Dapp Date: 2023-05-11 18:33 To: Palmer Dabbelt CC: gcc-patches; juzhe.zhong; Kito Cheng; collison; jeffreyalaw; rdapp.gcc Subject: [PATCH v2] RISC-V: Split off shift patterns for autovectorization

[PATCH v2] RISC-V: Split off shift patterns for autovectorization.

2023-05-11 Thread Robin Dapp via Gcc-patches
> "csr_operand" does seem wrong, though, as that just accepts constants. > Maybe "arith_operand" is the way to go? I haven't looked at the > V immediates though. I was pondering changing the shift-count operand to QImode everywhere but that indeed does not help code generation across the board.