Re: [PATCH v2] RISC-V: Handle multi-letter extension for multilib-generator

2020-07-01 Thread Kito Cheng
Hi Jim: Committed, thanks. On Thu, Jul 2, 2020 at 7:28 AM Jim Wilson wrote: > > On Wed, Jul 1, 2020 at 12:13 AM Kito Cheng wrote: > > * config/riscv/multilib-generator (arch_canonicalize): Handle > > multi-letter extension. > > Using underline as separator between differ

Re: [PATCH v2] RISC-V: Handle multi-letter extension for multilib-generator

2020-07-01 Thread Jim Wilson
On Wed, Jul 1, 2020 at 12:13 AM Kito Cheng wrote: > * config/riscv/multilib-generator (arch_canonicalize): Handle > multi-letter extension. > Using underline as separator between different extensions. Looks fine to me. Though I was expecting you to just commit the patch w

[PATCH v2] RISC-V: Handle multi-letter extension for multilib-generator

2020-07-01 Thread Kito Cheng
- The order of multi-lib config could be wrong if multi-ltter are used, e.g. `./multilib-generator rv32izfh-ilp32--c`, would expect rv32ic_zfh/ilp32 reuse rv32i_zfh/ilp32, however the multi-ltter is not handled correctly, it will generate reuse rule for rv32izfhc/ilp32 which is invalid