Re: [PATCH v2] PR target/98743: Fix ICE in convert_move for RISC-V

2021-02-02 Thread Kito Cheng
Hi Jakub: Thanks for your review, committed with testcase movement. On Tue, Feb 2, 2021 at 4:41 PM Jakub Jelinek wrote: > > On Tue, Feb 02, 2021 at 03:21:24PM +0800, Kito Cheng wrote: > > - Check `from` mode is not BLMmode before call store_expr, calling > > store_expr > >with BLKmode will

Re: [PATCH v2] PR target/98743: Fix ICE in convert_move for RISC-V

2021-02-02 Thread Jakub Jelinek via Gcc-patches
On Tue, Feb 02, 2021 at 03:21:24PM +0800, Kito Cheng wrote: > - Check `from` mode is not BLMmode before call store_expr, calling store_expr >with BLKmode will cause ICE. > > - Verified with riscv64, x86_64 and aarch64, no introduce new regression. > > Note: Those logic was introduced by 3e6

[PATCH v2] PR target/98743: Fix ICE in convert_move for RISC-V

2021-02-01 Thread Kito Cheng
- Check `from` mode is not BLMmode before call store_expr, calling store_expr with BLKmode will cause ICE. - Verified with riscv64, x86_64 and aarch64, no introduce new regression. Note: Those logic was introduced by 3e60ddeb8220ed388819bb3f14e8caa9309fd3c2, so I cc Jakub for reivew.