Re: [PATCH v2] MIPS: MIPS32r2 FP MADD instruction set support

2013-07-16 Thread Maciej W. Rozycki
On Tue, 16 Jul 2013, Richard Sandiford wrote: > > I only checked executables, these tests do not produce any. I didn't > > think of checking tests that do not produce executables, because they do > > not check run-time validity of code produced. These three tests you've > > referred to all p

Re: [PATCH v2] MIPS: MIPS32r2 FP MADD instruction set support

2013-07-16 Thread Richard Sandiford
"Maciej W. Rozycki" writes: > On Tue, 16 Jul 2013, Richard Sandiford wrote: > >> > I have regression-tested this change with the mips-linux-gnu target and >> > the mips32r2/o32 multilib. I have also verified that the instructions >> > affected were absent across the binaries produced by the te

Re: [PATCH v2] MIPS: MIPS32r2 FP MADD instruction set support

2013-07-16 Thread Maciej W. Rozycki
On Tue, 16 Jul 2013, Richard Sandiford wrote: > > I have regression-tested this change with the mips-linux-gnu target and > > the mips32r2/o32 multilib. I have also verified that the instructions > > affected were absent across the binaries produced by the testsuite before > > applying this c

Re: [PATCH v2] MIPS: MIPS32r2 FP MADD instruction set support

2013-07-16 Thread Richard Sandiford
"Maciej W. Rozycki" writes: > I have regression-tested this change with the mips-linux-gnu target and > the mips32r2/o32 multilib. I have also verified that the instructions > affected were absent across the binaries produced by the testsuite before > applying this change and present afterwar

[PATCH v2] MIPS: MIPS32r2 FP MADD instruction set support

2013-07-16 Thread Maciej W. Rozycki
On Wed, 27 Feb 2013, Maciej W. Rozycki wrote: > > Maciej, in that case, the rest of the patch is OK for 4.9, thanks. > > I will apply in due course then, thanks for your review. Regrettably after further investigation I have realised the change I proposed inadvertently enables more than just