Re: [PATCH v2] Fix use of singleton in optinfo framework (PING)

2020-06-22 Thread Gustavo Romero via Gcc-patches
Hi folks, On 5/26/20 8:15 PM, Gerald Pfeifer wrote: Okay to backport c00568f376078129196740d83946d54dc5437401 to the GCC 9 branch, Jakub? I don't see it yet on 9, so if 9 is still open for pushes I'd like too to see that commit applied to 9 (it should apply cleanly). For the records, the comm

Re: [PATCH v2] Fix use of singleton in optinfo framework

2020-05-26 Thread Gerald Pfeifer
Okay to backport c00568f376078129196740d83946d54dc5437401 to the GCC 9 branch, Jakub? Thanks, Gerald On Tue, 7 Apr 2020, Gustavo Romero via Gcc-patches wrote: > Currently an use of get() method of dump_context singleton in optinfo > framework causes a new class to be instantiated and when its dt

Re: [PATCH v2] Fix use of singleton in optinfo framework

2020-04-15 Thread Jakub Jelinek via Gcc-patches
On Tue, Apr 07, 2020 at 11:12:48PM -0400, Gustavo Romero via Gcc-patches wrote: > Currently an use of get() method of dump_context singleton in optinfo > framework causes a new class to be instantiated and when its dtor > is called it calls delete on uninitialized data, causing an ICE. To be preci

Re: [PATCH v2] Fix use of singleton in optinfo framework

2020-04-14 Thread Piotr Kubaj via Gcc-patches
I have already bisected GCC 10 issue here https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89494 The problem is commit 634afa05a8cbff010480088811fe1f39eca70c1d. On 20-04-14 21:11:01, Iain Sandoe wrote: Gerald Pfeifer wrote: On Tue, 7 Apr 2020, Gustavo Romero via Gcc-patches wrote: gcc/Changelog

Re: [PATCH v2] Fix use of singleton in optinfo framework

2020-04-14 Thread Iain Sandoe via Gcc-patches
Gerald Pfeifer wrote: On Tue, 7 Apr 2020, Gustavo Romero via Gcc-patches wrote: gcc/Changelog: 2020-04-06 Gustavo Romero * dumpfile.c: (selftest::temp_dump_context::temp_dump_context): Fix ctor. If you approve (David, Jakub, or someone else) I can take care of committing

Re: [PATCH v2] Fix use of singleton in optinfo framework

2020-04-11 Thread Gerald Pfeifer
On Tue, 7 Apr 2020, Gustavo Romero via Gcc-patches wrote: > gcc/Changelog: > 2020-04-06 Gustavo Romero > > * dumpfile.c: > (selftest::temp_dump_context::temp_dump_context): Fix ctor. If you approve (David, Jakub, or someone else) I can take care of committing this if you like. It

[PATCH v2] Fix use of singleton in optinfo framework

2020-04-07 Thread Gustavo Romero via Gcc-patches
Currently an use of get() method of dump_context singleton in optinfo framework causes a new class to be instantiated and when its dtor is called it calls delete on uninitialized data, causing an ICE. It happens when a temporary dump_context is instantiated for the 'm_saved' initialization in temp