Re: [PATCH v2] C/C++: Add -Waddress-of-packed-member

2018-06-18 Thread Joseph Myers
On Mon, 18 Jun 2018, Jason Merrill wrote: > On Mon, Jun 18, 2018 at 11:59 AM, Joseph Myers > wrote: > > On Mon, 18 Jun 2018, Jason Merrill wrote: > > > >> > + if (TREE_CODE (rhs) == COND_EXPR) > >> > +{ > >> > + /* Check the THEN path first. */ > >> > + tree op1 = TREE_OPERAND (r

Re: [PATCH v2] C/C++: Add -Waddress-of-packed-member

2018-06-18 Thread Jason Merrill
On Mon, Jun 18, 2018 at 11:59 AM, Joseph Myers wrote: > On Mon, 18 Jun 2018, Jason Merrill wrote: > >> > + if (TREE_CODE (rhs) == COND_EXPR) >> > +{ >> > + /* Check the THEN path first. */ >> > + tree op1 = TREE_OPERAND (rhs, 1); >> > + context = check_address_of_packed_member

Re: [PATCH v2] C/C++: Add -Waddress-of-packed-member

2018-06-18 Thread Joseph Myers
On Mon, 18 Jun 2018, Jason Merrill wrote: > > + if (TREE_CODE (rhs) == COND_EXPR) > > +{ > > + /* Check the THEN path first. */ > > + tree op1 = TREE_OPERAND (rhs, 1); > > + context = check_address_of_packed_member (type, op1); > > This should handle the GNU extension of re-u

Re: [PATCH v2] C/C++: Add -Waddress-of-packed-member

2018-06-18 Thread Jason Merrill
On Fri, May 18, 2018 at 7:36 AM, H.J. Lu wrote: > On Thu, May 17, 2018 at 10:32:56AM -0700, H.J. Lu wrote: >> On Mon, May 14, 2018 at 8:00 PM, Martin Sebor wrote: >> > On 05/14/2018 01:10 PM, H.J. Lu wrote: >> >> >> >> On Mon, May 14, 2018 at 10:40 AM, H.J. Lu wrote: >> >> >> >> $ cat c.i >>

PING^2: [PATCH v2] C/C++: Add -Waddress-of-packed-member

2018-06-12 Thread H.J. Lu
On Tue, May 29, 2018 at 5:15 AM, H.J. Lu wrote: > On Fri, May 18, 2018 at 4:36 AM, H.J. Lu wrote: >> On Thu, May 17, 2018 at 10:32:56AM -0700, H.J. Lu wrote: >>> On Mon, May 14, 2018 at 8:00 PM, Martin Sebor wrote: >>> > On 05/14/2018 01:10 PM, H.J. Lu wrote: >>> >> >>> >> On Mon, May 14, 2018 a

PING^1: [PATCH v2] C/C++: Add -Waddress-of-packed-member

2018-05-29 Thread H.J. Lu
On Fri, May 18, 2018 at 4:36 AM, H.J. Lu wrote: > On Thu, May 17, 2018 at 10:32:56AM -0700, H.J. Lu wrote: >> On Mon, May 14, 2018 at 8:00 PM, Martin Sebor wrote: >> > On 05/14/2018 01:10 PM, H.J. Lu wrote: >> >> >> >> On Mon, May 14, 2018 at 10:40 AM, H.J. Lu wrote: >> >> >> >> $ cat c.i >>

[PATCH v2] C/C++: Add -Waddress-of-packed-member

2018-05-18 Thread H.J. Lu
On Thu, May 17, 2018 at 10:32:56AM -0700, H.J. Lu wrote: > On Mon, May 14, 2018 at 8:00 PM, Martin Sebor wrote: > > On 05/14/2018 01:10 PM, H.J. Lu wrote: > >> > >> On Mon, May 14, 2018 at 10:40 AM, H.J. Lu wrote: > >> > >> $ cat c.i > >> struct B { int i; }; > >> struct C { struct B