Re: [PATCH v2] AIX visibility

2016-11-08 Thread Christophe Lyon
Hi David, On 8 November 2016 at 19:00, David Edelsohn wrote: > On Tue, Nov 8, 2016 at 10:23 AM, Christophe Lyon > wrote: >> Hi David, >> >> On 2 November 2016 at 16:41, David Edelsohn wrote: >>> This revised patch makes two changes: >>> >>> 1) Fix typo in configure.ac >>> 2) Add AIX visibility

Re: [PATCH v2] AIX visibility

2016-11-08 Thread David Edelsohn
On Tue, Nov 8, 2016 at 10:23 AM, Christophe Lyon wrote: > Hi David, > > On 2 November 2016 at 16:41, David Edelsohn wrote: >> This revised patch makes two changes: >> >> 1) Fix typo in configure.ac >> 2) Add AIX visibility support for ASM_WEAKEN_DECL, which does touch >> the same code as Linux. >

Re: [PATCH v2] AIX visibility

2016-11-08 Thread David Edelsohn
On Tue, Nov 8, 2016 at 10:23 AM, Christophe Lyon wrote: > Hi David, > > On 2 November 2016 at 16:41, David Edelsohn wrote: >> This revised patch makes two changes: >> >> 1) Fix typo in configure.ac >> 2) Add AIX visibility support for ASM_WEAKEN_DECL, which does touch >> the same code as Linux. >

Re: [PATCH v2] AIX visibility

2016-11-08 Thread Christophe Lyon
Hi David, On 2 November 2016 at 16:41, David Edelsohn wrote: > This revised patch makes two changes: > > 1) Fix typo in configure.ac > 2) Add AIX visibility support for ASM_WEAKEN_DECL, which does touch > the same code as Linux. > > The AIX "weak" support fixes a large number of C++ visibility te

Re: [PATCH v2] AIX visibility

2016-11-02 Thread Segher Boessenkool
On Wed, Nov 02, 2016 at 11:28:40AM -0500, Segher Boessenkool wrote: > On Wed, Nov 02, 2016 at 11:41:32AM -0400, David Edelsohn wrote: > > Any comments on ASM_WEAKEN_DECL change? > > It no longer checks RS6000_WEAK, is that always on now? Oh never mind, I can't read (it actually scrolled off my sc

Re: [PATCH v2] AIX visibility

2016-11-02 Thread Segher Boessenkool
On Wed, Nov 02, 2016 at 11:41:32AM -0400, David Edelsohn wrote: > Any comments on ASM_WEAKEN_DECL change? It no longer checks RS6000_WEAK, is that always on now? Otherwise looks fine to me. Segher

[PATCH v2] AIX visibility

2016-11-02 Thread David Edelsohn
This revised patch makes two changes: 1) Fix typo in configure.ac 2) Add AIX visibility support for ASM_WEAKEN_DECL, which does touch the same code as Linux. The AIX "weak" support fixes a large number of C++ visibility testcases. Bootstrapped on powerpc-ibm-aix7.2.0.0. * configure.ac (.hidden)