Re: [PATCH v2] AArch64: Fix copysign patterns

2024-09-23 Thread Saurabh Jha
On 9/20/2024 10:51 AM, Christophe Lyon wrote: Hi Saurabh, On 9/18/24 21:53, Saurabh Jha wrote: Hi Wilco, Thanks for the patch. This mostly looks good. Just added a couple clarifications. On 9/18/2024 8:17 PM, Wilco Dijkstra wrote: v2: Add more testcase fixes. The current copysign pattern

Re: [PATCH v2] AArch64: Fix copysign patterns

2024-09-20 Thread Christophe Lyon
Hi Saurabh, On 9/18/24 21:53, Saurabh Jha wrote: Hi Wilco, Thanks for the patch. This mostly looks good. Just added a couple clarifications. On 9/18/2024 8:17 PM, Wilco Dijkstra wrote: v2: Add more testcase fixes. The current copysign pattern has a mismatch in the predicates and constrain

Re: [PATCH v2] AArch64: Fix copysign patterns

2024-09-20 Thread Richard Sandiford
Wilco Dijkstra writes: > v2: Add more testcase fixes. > > The current copysign pattern has a mismatch in the predicates and constraints > - > operand[2] is a register_operand but also has an alternative X which allows > any > operand. Since it is a floating point operation, having an integer >

Re: [PATCH v2] AArch64: Fix copysign patterns

2024-09-18 Thread Saurabh Jha
Hi Wilco, Thanks for the patch. This mostly looks good. Just added a couple clarifications. On 9/18/2024 8:17 PM, Wilco Dijkstra wrote: v2: Add more testcase fixes. The current copysign pattern has a mismatch in the predicates and constraints - operand[2] is a register_operand but also has a

[PATCH v2] AArch64: Fix copysign patterns

2024-09-18 Thread Wilco Dijkstra
v2: Add more testcase fixes. The current copysign pattern has a mismatch in the predicates and constraints - operand[2] is a register_operand but also has an alternative X which allows any operand. Since it is a floating point operation, having an integer alternative makes no sense. Change the e