Re: [PATCH v2] [4.6] shared_ptr needs explicit copy constructor

2012-01-03 Thread Jonathan Wakely
On 3 January 2012 21:48, Chase Douglas wrote: > On 01/03/2012 01:38 PM, Jonathan Wakely wrote: >> I get testsuite failures with this change applied: >> >> FAIL: 20_util/shared_ptr/cons/43820_neg.cc  (test for errors, line 858) >> FAIL: 20_util/shared_ptr/cons/43820_neg.cc (test for excess errors) >

Re: [PATCH v2] [4.6] shared_ptr needs explicit copy constructor

2012-01-03 Thread Chase Douglas
On 01/03/2012 01:38 PM, Jonathan Wakely wrote: > I get testsuite failures with this change applied: > > FAIL: 20_util/shared_ptr/cons/43820_neg.cc (test for errors, line 858) > FAIL: 20_util/shared_ptr/cons/43820_neg.cc (test for excess errors) > FAIL: 20_util/weak_ptr/comparison/cmp_neg.cc (tes

Re: [PATCH v2] [4.6] shared_ptr needs explicit copy constructor

2012-01-03 Thread Jonathan Wakely
I get testsuite failures with this change applied: FAIL: 20_util/shared_ptr/cons/43820_neg.cc (test for errors, line 858) FAIL: 20_util/shared_ptr/cons/43820_neg.cc (test for excess errors) FAIL: 20_util/weak_ptr/comparison/cmp_neg.cc (test for warnings, line 354) FAIL: 20_util/weak_ptr/comparis

Re: [PATCH v2] [4.6] shared_ptr needs explicit copy constructor

2012-01-03 Thread Jonathan Wakely
On 3 January 2012 20:45, Chase Douglas wrote: > On 01/03/2012 12:34 PM, Jonathan Wakely wrote: >> On 3 January 2012 19:17, Chase Douglas wrote: >>> >>> PR c++/50500 >>> * include/bits/shared_ptr.h: Add lazy copy ops even if there's a move >> >> That is the ChangeLog for the front-end part of 50500,

Re: [PATCH v2] [4.6] shared_ptr needs explicit copy constructor

2012-01-03 Thread Chase Douglas
On 01/03/2012 12:34 PM, Jonathan Wakely wrote: > On 3 January 2012 19:17, Chase Douglas wrote: >> >> PR c++/50500 >> * include/bits/shared_ptr.h: Add lazy copy ops even if there's a move > > That is the ChangeLog for the front-end part of 50500, isn't it? > Should be something like "Default copy c

Re: [PATCH v2] [4.6] shared_ptr needs explicit copy constructor

2012-01-03 Thread Jonathan Wakely
On 3 January 2012 19:17, Chase Douglas wrote: > > PR c++/50500 > * include/bits/shared_ptr.h: Add lazy copy ops even if there's a move That is the ChangeLog for the front-end part of 50500, isn't it? Should be something like "Default copy ctor and assignment." Otherwise this is OK to check in, th

[PATCH v2] [4.6] shared_ptr needs explicit copy constructor

2012-01-03 Thread Chase Douglas
When compiling with a compiler that is conformant to the c++11 spec for PR c++/50500, std::shared_ptr must have an explicitly defined copy constructor. Backported from revisions 180159 and 173882. The rest of the revisions include new functionality, so only this part should be applied to 4.6. Thi